| Message ID | 20230625080916.3553621-4-guoniu.zhou@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | add ISI support for i.MX93 | expand |
On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote: > From: "Guoniu.zhou" <guoniu.zhou@nxp.com> > > Add i.MX93 support since it reuse ISI which used in i.MX8M family. > > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com> Subject: Drop duplicated "media:" > --- > Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > index 1ce9440bde32..ddad1d8778f3 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > @@ -21,6 +21,7 @@ properties: > enum: > - fsl,imx8mn-isi > - fsl,imx8mp-isi > + - fsl,imx93-isi Imx93 is a family of devices, not specific device, so I hope you understand that it is a bit against the recommendation of specific compatibles and you guarantee that all devices within family will be identical. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof
Hi Krzysztof Kozlowski, Got it, will update. Thanks for your quick reviewing. > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2023年6月25日 16:22 > To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>; linux-media@vger.kernel.org; > dl-linux-imx <linux-imx@nxp.com>; devicetree@vger.kernel.org > Cc: laurent.pinchart@ideasonboard.com; mchehab@kernel.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > Xavier Roumegue (OSS) <xavier.roumegue@oss.nxp.com>; > kernel@pengutronix.de; jacopo.mondi@ideasonboard.com; > sakari.ailus@linux.intel.com > Subject: Re: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support > > Caution: This is an external email. Please take care when clicking links or opening > attachments. When in doubt, report the message using the 'Report this email' > button > > > On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote: > > From: "Guoniu.zhou" <guoniu.zhou@nxp.com> > > > > Add i.MX93 support since it reuse ISI which used in i.MX8M family. > > > > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com> > > Subject: Drop duplicated "media:" > > > --- > > Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > index 1ce9440bde32..ddad1d8778f3 100644 > > --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > @@ -21,6 +21,7 @@ properties: > > enum: > > - fsl,imx8mn-isi > > - fsl,imx8mp-isi > > + - fsl,imx93-isi > > Imx93 is a family of devices, not specific device, so I hope you understand that it > is a bit against the recommendation of specific compatibles and you guarantee > that all devices within family will be identical. > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > This is an automated instruction, just in case, because many review tags are > being ignored. If you do not know the process, here is a short > explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, > under or above your Signed-off-by tag. Tools like b4 can help here. However, > there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for acks received on the version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submittin > g-patches.rst#L540 > > Best regards, > Krzysztof
Hi Krzysztof Kozlowski, > -----Original Message----- > From: G.N. Zhou (OSS) > Sent: 2023年6月25日 16:28 > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; G.N. Zhou (OSS) > <guoniu.zhou@oss.nxp.com>; linux-media@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com>; devicetree@vger.kernel.org > Cc: laurent.pinchart@ideasonboard.com; mchehab@kernel.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > Xavier Roumegue (OSS) <xavier.roumegue@oss.nxp.com>; > kernel@pengutronix.de; jacopo.mondi@ideasonboard.com; > sakari.ailus@linux.intel.com > Subject: RE: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support > > Hi Krzysztof Kozlowski, > > Got it, will update. Thanks for your quick reviewing. > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Sent: 2023年6月25日 16:22 > > To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>; > > linux-media@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > > devicetree@vger.kernel.org > > Cc: laurent.pinchart@ideasonboard.com; mchehab@kernel.org; > > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > robh+conor+dt@kernel.org; > > Xavier Roumegue (OSS) <xavier.roumegue@oss.nxp.com>; > > kernel@pengutronix.de; jacopo.mondi@ideasonboard.com; > > sakari.ailus@linux.intel.com > > Subject: Re: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: > > i.MX93 support > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. When in doubt, report the message using the > 'Report this email' > > button > > > > > > On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote: > > > From: "Guoniu.zhou" <guoniu.zhou@nxp.com> > > > > > > Add i.MX93 support since it reuse ISI which used in i.MX8M family. > > > > > > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com> > > > > Subject: Drop duplicated "media:" > > > > > --- > > > Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > > b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > > index 1ce9440bde32..ddad1d8778f3 100644 > > > --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > > +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml > > > @@ -21,6 +21,7 @@ properties: > > > enum: > > > - fsl,imx8mn-isi > > > - fsl,imx8mp-isi > > > + - fsl,imx93-isi > > > > Imx93 is a family of devices, not specific device, so I hope you > > understand that it is a bit against the recommendation of specific > > compatibles and you guarantee that all devices within family will be identical. I'm litter confused about this since iMX93 is a specific device and belong to iMX9 family. Could you help to provide more details? > > > > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > > --- > > > > This is an automated instruction, just in case, because many review > > tags are being ignored. If you do not know the process, here is a > > short > > explanation: > > > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > > versions, under or above your Signed-off-by tag. Tools like b4 can > > help here. However, there's no need to repost patches *only* to add the tags. > > The upstream maintainer will do that for acks received on the version they > apply. > > > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/su > > bmittin > > g-patches.rst#L540 Thanks for you reminding. > > > > Best regards, > > Krzysztof
diff --git a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml index 1ce9440bde32..ddad1d8778f3 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml @@ -21,6 +21,7 @@ properties: enum: - fsl,imx8mn-isi - fsl,imx8mp-isi + - fsl,imx93-isi reg: maxItems: 1 @@ -72,7 +73,9 @@ allOf: properties: compatible: contains: - const: fsl,imx8mn-isi + enum: + - fsl,imx8mn-isi + - fsl,imx93-isi then: properties: interrupts: