| Message ID | 20230707063335.13317-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFT,v2,1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 | expand |
On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > [...] Applied, thanks! [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27 [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56 Best regards,
Am Montag, 10. Juli 2023, 16:16:20 CEST schrieb Heiko Stuebner: > On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > > > Correct the interrupt flags, assuming the author of the code wanted same > > logical behavior behind the name "ACTIVE_xxx", this is: > > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > > > [...] > > Applied, thanks! > > [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 > commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27 > [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B > commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e > [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo > commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56 we got one successful test and all the changes concern broadcom wifi modules, I assume that this should work on all of them the same :-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>;
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. Correct subject and commit msg (active low -> high) --- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)