diff mbox series

leds: pwm: Fix error code in led_pwm_create_fwnode()

Message ID a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
State New
Headers show
Series leds: pwm: Fix error code in led_pwm_create_fwnode() | expand

Commit Message

Dan Carpenter July 11, 2023, 6:13 a.m. UTC 
Negative -EINVAL was intended, not positive EINVAL.  Fix it.

Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/leds/leds-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lee Jones July 13, 2023, 2:55 p.m. UTC | #1 
On Tue, 11 Jul 2023, Dan Carpenter wrote:

> Negative -EINVAL was intended, not positive EINVAL.  Fix it.
> 
> Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/leds/leds-pwm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 29194cc382af..87c199242f3c 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -146,7 +146,7 @@  static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
 			led.name = to_of_node(fwnode)->name;
 
 		if (!led.name) {
-			ret = EINVAL;
+			ret = -EINVAL;
 			goto err_child_out;
 		}