[v2,0/3] firmware: scpi: add device power domain support

Message ID 1466082894.20208.1.camel@linaro.org
State New
Headers show

Commit Message

Jon Medhurst (Tixy) June 16, 2016, 1:14 p.m.
On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote:
> This series add support for SCPI based device device power state

> management using genpd.

> 

> Regards,

> Sudeep

> 

> v1[1]->v2:

> 	- Fixed the endianness handling in scpi_device_get_power_state

> 	  as spotted by Tixy

> 	- Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf


You seemed to also have made some changes to the contents of the file,
is that deliberate? This is the diff...

 static int scpi_pd_power_on(struct generic_pm_domain *domain)

Patch hide | download patch | download mbox

--- a/drivers/firmware/scpi_pm_domain.c
+++ b/drivers/firmware/scpi_pd.c
@@ -27,7 +27,7 @@  struct scpi_pm_domain {
        struct generic_pm_domain genpd;
        struct scpi_ops *ops;
        u32 domain;
-       char name[20];
+       char name[30];
 };
 
 enum scpi_power_domain_state {
@@ -51,7 +51,7 @@  static int scpi_pd_power(struct scpi_pm_domain *pd,
bool power_on)
        if (ret)
                return ret;
 
-       return (state == pd->ops->device_get_power_state(pd->domain));
+       return !(state == pd->ops->device_get_power_state(pd->domain));
 }