From patchwork Thu Jun 16 15:58:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 70196 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp336320qgy; Thu, 16 Jun 2016 09:01:47 -0700 (PDT) X-Received: by 10.159.35.207 with SMTP id 73mr2432702uao.13.1466092907614; Thu, 16 Jun 2016 09:01:47 -0700 (PDT) Return-Path: Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com. [209.132.183.37]) by mx.google.com with ESMTPS id l62si14785321vke.208.2016.06.16.09.01.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2016 09:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.37 as permitted sender) client-ip=209.132.183.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.37 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5GFx1Xv010758; Thu, 16 Jun 2016 11:59:01 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u5GFwxLl020763 for ; Thu, 16 Jun 2016 11:58:59 -0400 Received: from [10.3.116.154] (ovpn-116-154.phx2.redhat.com [10.3.116.154]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5GFwxqC022012; Thu, 16 Jun 2016 11:58:59 -0400 To: Jovanka Gulicoska , libvir-list@redhat.com References: <1466064541-27880-1-git-send-email-jovanka.gulicoska@gmail.com> <1466064541-27880-8-git-send-email-jovanka.gulicoska@gmail.com> From: Cole Robinson Message-ID: <723272b5-670e-bce8-9203-6de641756e8b@redhat.com> Date: Thu, 16 Jun 2016 11:58:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466064541-27880-8-git-send-email-jovanka.gulicoska@gmail.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-loop: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH python v4 7/7] virsh: Introduce virsh-pool command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com On 06/16/2016 04:09 AM, Jovanka Gulicoska wrote: > Add virsh-pool support for storage pool lifecycle events > --- > tools/virsh-pool.c | 184 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 184 insertions(+) > I needed this diff to get things working: Also, please extend tools/virsh.pod so this option is documented in the man page. Thanks, Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index cd40749..18e218c 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1966,7 +1966,7 @@ static const vshCmdInfo info_pool_event[] = { }; static const vshCmdOptDef opts_pool_event[] = { - {.name = "storage pool", + {.name = "pool", .type = VSH_OT_STRING, .help = N_("filter by storage pool name or uuid") },