From patchwork Thu Jun 16 16:22:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 70199 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp348260qgy; Thu, 16 Jun 2016 09:25:33 -0700 (PDT) X-Received: by 10.200.39.33 with SMTP id g30mr5936611qtg.16.1466094333107; Thu, 16 Jun 2016 09:25:33 -0700 (PDT) Return-Path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com. [209.132.183.24]) by mx.google.com with ESMTPS id m64si13835591qtd.115.2016.06.16.09.25.32 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 16 Jun 2016 09:25:33 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) client-ip=209.132.183.24; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u5GGMis5010422; Thu, 16 Jun 2016 12:22:45 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u5GGMheM025578 for ; Thu, 16 Jun 2016 12:22:43 -0400 Received: from [10.3.116.154] (ovpn-116-154.phx2.redhat.com [10.3.116.154]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5GGMgZL015175; Thu, 16 Jun 2016 12:22:42 -0400 To: Jovanka Gulicoska , libvir-list@redhat.com References: <1466064541-27880-1-git-send-email-jovanka.gulicoska@gmail.com> <1466064541-27880-5-git-send-email-jovanka.gulicoska@gmail.com> From: Cole Robinson Message-ID: <1e73cde6-26d4-6b76-7af1-a68a97a82de5@redhat.com> Date: Thu, 16 Jun 2016 12:22:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466064541-27880-5-git-send-email-jovanka.gulicoska@gmail.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-loop: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH python v4 4/7] remote: implement storage lifecycle event APIs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com Something weird happened with the series titles, they have 'python' in the name! Did you trigger send-email from the libvirt-python.git directory, or maybe you edited .git/config in the wrong repo? Anyways, I've pushed patches 1-6 with the following changes to this patch: On 06/16/2016 04:08 AM, Jovanka Gulicoska wrote: > --- > daemon/libvirtd.h | 2 + > daemon/remote.c | 207 ++++++++++++++++++++++++++++++++++++++++++- > src/remote/remote_driver.c | 128 ++++++++++++++++++++++++++ > src/remote/remote_protocol.x | 43 ++++++++- > src/remote_protocol-structs | 19 ++++ > 5 files changed, 395 insertions(+), 4 deletions(-) > diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h > index 7271b0f..cc91266 100644 > --- a/daemon/libvirtd.h > +++ b/daemon/libvirtd.h > @@ -208,7 +234,6 @@ remoteRelayDomainQemuMonitorEventCheckACL(virNetServerClientPtr client, > return ret; > } > > - > static int > remoteRelayDomainEventLifecycle(virConnectPtr conn, > virDomainPtr dom, Dropped this spurious change > diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c > index f494cbf..62deecd 100644 > --- a/src/remote/remote_driver.c > +++ b/src/remote/remote_driver.c > @@ -7908,6 +8034,8 @@ static virStorageDriver storage_driver = { > .connectListDefinedStoragePools = remoteConnectListDefinedStoragePools, /* 0.4.1 */ > .connectListAllStoragePools = remoteConnectListAllStoragePools, /* 0.10.2 */ > .connectFindStoragePoolSources = remoteConnectFindStoragePoolSources, /* 0.4.5 */ > + .connectStoragePoolEventDeregisterAny = remoteConnectStoragePoolEventDeregisterAny, /* 1.3.6 */ > + .connectStoragePoolEventRegisterAny = remoteConnectStoragePoolEventRegisterAny, /* 1.3.6 */ > .storagePoolLookupByName = remoteStoragePoolLookupByName, /* 0.4.1 */ > .storagePoolLookupByUUID = remoteStoragePoolLookupByUUID, /* 0.4.1 */ > .storagePoolLookupByVolume = remoteStoragePoolLookupByVolume, /* 0.4.1 */ Switched this reference to 2.0.0 > diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs > index fe1b8a8..2d7299d 100644 > --- a/src/remote_protocol-structs > +++ b/src/remote_protocol-structs > @@ -2551,6 +2551,22 @@ struct remote_network_event_lifecycle_msg { > int event; > int detail; > }; > +struct remote_connect_storage_pool_event_register_any_args { > + int eventID; > + remote_storage_pool pool; > +}; > +struct remote_connect_storage_pool_event_register_any_ret { > + int callbackID; > +}; > +struct remote_connect_storage_pool_event_deregister_any_args { > + int callbackID; > +}; > +struct remote_storage_pool_event_lifecycle_msg { > + int callbackID; > + remote_nonnull_storage_pool pool; > + int event; > + int detail; > +}; > struct remote_domain_fsfreeze_args { > remote_nonnull_domain dom; > struct { > @@ -3103,4 +3119,7 @@ enum remote_procedure { > REMOTE_PROC_DOMAIN_GET_PERF_EVENTS = 365, > REMOTE_PROC_DOMAIN_SET_PERF_EVENTS = 366, > REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVAL_FAILED = 367, > + REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_REGISTER_ANY = 368, > + REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_DEREGISTER_ANY = 369, > + REMOTE_PROC_STORAGE_POOL_EVENT_LIFECYCLE = 370, > }; > I installed latest pdwtags so I can actually run the protocol-structs test, and it was still missing this diff, which is squashed in now: Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 2d7299d..3934e07 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -2552,20 +2552,20 @@ struct remote_network_event_lifecycle_msg { int detail; }; struct remote_connect_storage_pool_event_register_any_args { - int eventID; - remote_storage_pool pool; + int eventID; + remote_storage_pool pool; }; struct remote_connect_storage_pool_event_register_any_ret { - int callbackID; + int callbackID; }; struct remote_connect_storage_pool_event_deregister_any_args { - int callbackID; + int callbackID;git }; struct remote_storage_pool_event_lifecycle_msg { - int callbackID; - remote_nonnull_storage_pool pool; - int event; - int detail; + int callbackID; + remote_nonnull_storage_pool pool; + int event; + int detail; }; Thanks,