thermal: hisilicon: Add dependency on the clock driver to allow frequency scaling

Message ID f6bbd7ddf978001aa0f1c6fb8fc454a30241d0a8.1466424352.git.amit.kucheria@linaro.org
State New
Headers show

Commit Message

Amit Kucheria June 20, 2016, 12:16 p.m.
The Hisilicon clock stub driver is needed to allow the thermal drivers to
actually scale the frequency. Make it an automatic dependency.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

---
 drivers/thermal/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Amit Kucheria June 26, 2016, 4:32 p.m. | #1
On Mon, Jun 20, 2016 at 6:46 PM, Leo Yan <leo.yan@linaro.org> wrote:
> Hi Amit,

>

> On Mon, Jun 20, 2016 at 05:46:36PM +0530, Amit Kucheria wrote:

>> The Hisilicon clock stub driver is needed to allow the thermal drivers to

>> actually scale the frequency. Make it an automatic dependency.

>>

>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

>> ---

>>  drivers/thermal/Kconfig | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig

>> index 22ae1f7..4e843f7 100644

>> --- a/drivers/thermal/Kconfig

>> +++ b/drivers/thermal/Kconfig

>> @@ -178,6 +178,7 @@ config THERMAL_EMULATION

>>  config HISI_THERMAL

>>       tristate "Hisilicon thermal driver"

>>       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

>> +     select STUB_CLK_HI6220

>

> Acked-by: Leo Yan <leo.yan@linaro.org>


Thanks Leo. Eduardo, will you take this through your tree or should
Wei include this in his tree?

Regards,
Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Amit Kucheria July 7, 2016, 6:43 a.m. | #2
On Sun, Jun 26, 2016 at 10:02 PM, Amit Kucheria
<amit.kucheria@linaro.org> wrote:
> On Mon, Jun 20, 2016 at 6:46 PM, Leo Yan <leo.yan@linaro.org> wrote:

>> Hi Amit,

>>

>> On Mon, Jun 20, 2016 at 05:46:36PM +0530, Amit Kucheria wrote:

>>> The Hisilicon clock stub driver is needed to allow the thermal drivers to

>>> actually scale the frequency. Make it an automatic dependency.

>>>

>>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

>>> ---

>>>  drivers/thermal/Kconfig | 1 +

>>>  1 file changed, 1 insertion(+)

>>>

>>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig

>>> index 22ae1f7..4e843f7 100644

>>> --- a/drivers/thermal/Kconfig

>>> +++ b/drivers/thermal/Kconfig

>>> @@ -178,6 +178,7 @@ config THERMAL_EMULATION

>>>  config HISI_THERMAL

>>>       tristate "Hisilicon thermal driver"

>>>       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

>>> +     select STUB_CLK_HI6220

>>

>> Acked-by: Leo Yan <leo.yan@linaro.org>

>

> Thanks Leo. Eduardo, will you take this through your tree or should

> Wei include this in his tree?


Ping!
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wei Xu July 25, 2016, 1:19 p.m. | #3
On 25/07/2016 13:29, Amit Kucheria wrote:
> On Thu, Jul 7, 2016 at 12:13 PM, Amit Kucheria <amit.kucheria@linaro.org> wrote:

>> On Sun, Jun 26, 2016 at 10:02 PM, Amit Kucheria

>> <amit.kucheria@linaro.org> wrote:

>>> On Mon, Jun 20, 2016 at 6:46 PM, Leo Yan <leo.yan@linaro.org> wrote:

>>>> Hi Amit,

>>>>

>>>> On Mon, Jun 20, 2016 at 05:46:36PM +0530, Amit Kucheria wrote:

>>>>> The Hisilicon clock stub driver is needed to allow the thermal drivers to

>>>>> actually scale the frequency. Make it an automatic dependency.

>>>>>

>>>>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

>>>>> ---

>>>>>  drivers/thermal/Kconfig | 1 +

>>>>>  1 file changed, 1 insertion(+)

>>>>>

>>>>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig

>>>>> index 22ae1f7..4e843f7 100644

>>>>> --- a/drivers/thermal/Kconfig

>>>>> +++ b/drivers/thermal/Kconfig

>>>>> @@ -178,6 +178,7 @@ config THERMAL_EMULATION

>>>>>  config HISI_THERMAL

>>>>>       tristate "Hisilicon thermal driver"

>>>>>       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

>>>>> +     select STUB_CLK_HI6220

>>>>

>>>> Acked-by: Leo Yan <leo.yan@linaro.org>

>>>

>>> Thanks Leo. Eduardo, will you take this through your tree or should

>>> Wei include this in his tree?

>>

>> Ping!


Hi Amit

> 

> Wei, could you pull this into your tree for the next release?


I am OK If Eduardo is OK to pick up my pull request.

Hi Eduardo,

Is it OK for me to send a pull request to you about this?
Or could you let us know whether you could directly pick it up?
Thanks!

Best Regards,
Wei

> 

> 


--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Amit Kucheria Aug. 1, 2016, 6:13 a.m. | #4
On Mon, Jul 25, 2016 at 6:49 PM, Wei Xu <xuwei5@hisilicon.com> wrote:
>

>

> On 25/07/2016 13:29, Amit Kucheria wrote:

>> On Thu, Jul 7, 2016 at 12:13 PM, Amit Kucheria <amit.kucheria@linaro.org> wrote:

>>> On Sun, Jun 26, 2016 at 10:02 PM, Amit Kucheria

>>> <amit.kucheria@linaro.org> wrote:

>>>> On Mon, Jun 20, 2016 at 6:46 PM, Leo Yan <leo.yan@linaro.org> wrote:

>>>>> Hi Amit,

>>>>>

>>>>> On Mon, Jun 20, 2016 at 05:46:36PM +0530, Amit Kucheria wrote:

>>>>>> The Hisilicon clock stub driver is needed to allow the thermal drivers to

>>>>>> actually scale the frequency. Make it an automatic dependency.

>>>>>>

>>>>>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

>>>>>> ---

>>>>>>  drivers/thermal/Kconfig | 1 +

>>>>>>  1 file changed, 1 insertion(+)

>>>>>>

>>>>>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig

>>>>>> index 22ae1f7..4e843f7 100644

>>>>>> --- a/drivers/thermal/Kconfig

>>>>>> +++ b/drivers/thermal/Kconfig

>>>>>> @@ -178,6 +178,7 @@ config THERMAL_EMULATION

>>>>>>  config HISI_THERMAL

>>>>>>       tristate "Hisilicon thermal driver"

>>>>>>       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

>>>>>> +     select STUB_CLK_HI6220

>>>>>

>>>>> Acked-by: Leo Yan <leo.yan@linaro.org>

>>>>

>>>> Thanks Leo. Eduardo, will you take this through your tree or should

>>>> Wei include this in his tree?

>>>

>>> Ping!

>

> Hi Amit

>

>>

>> Wei, could you pull this into your tree for the next release?

>

> I am OK If Eduardo is OK to pick up my pull request.

>

> Hi Eduardo,

>

> Is it OK for me to send a pull request to you about this?

> Or could you let us know whether you could directly pick it up?

> Thanks!


Wei, if you can sign-off on this, perhaps Zhang can pick it up? I
haven't heard from Eduardo for over a month.
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 22ae1f7..4e843f7 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -178,6 +178,7 @@  config THERMAL_EMULATION
 config HISI_THERMAL
 	tristate "Hisilicon thermal driver"
 	depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
+	select STUB_CLK_HI6220
 	help
 	  Enable this to plug hisilicon's thermal sensor driver into the Linux
 	  thermal framework. cpufreq is used as the cooling device to throttle