mbox series

[GIT,PULL,FOR,v6.6] Various cec fixes

Message ID c59cff3f-bdba-7f84-74d1-26b37d6cbeeb@xs4all.nl
State New
Headers show
Series [GIT,PULL,FOR,v6.6] Various cec fixes | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.6b

Message

Hans Verkuil July 19, 2023, 11:36 a.m. UTC
Even though two of the patches have a Fixes tag, there is nothing here that
is important for 6.5.

Regards,

	Hans

The following changes since commit 28999781d15f94046e6c23a9a7d92ad28a436abf:

  media: i2c: ov01a10: Switch back to use struct i2c_driver::probe (2023-07-19 12:57:51 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.6b

for you to fetch changes up to 0009a07acd07ee6231b731fc3030e3bbc450bee6:

  cec-pin: only enable interrupts when monitoring the CEC pin (2023-07-19 13:15:37 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (7):
      media: cec: core: add adap_nb_transmit_canceled() callback
      media: cec: core: add adap_unconfigured() callback
      Documentation: media: cec: describe new callbacks
      cec-gpio: specify IRQF_NO_AUTOEN when requesting irq
      cec-pin: improve interrupt handling
      cec-gpio: drop the cec_gpio_free callback
      cec-pin: only enable interrupts when monitoring the CEC pin

 Documentation/driver-api/media/cec-core.rst    | 44 ++++++++++++++++++++++++++++++++++----------
 drivers/media/cec/core/cec-adap.c              |  8 ++++----
 drivers/media/cec/core/cec-pin-priv.h          |  1 +
 drivers/media/cec/core/cec-pin.c               | 32 ++++++++++++++++++++++----------
 drivers/media/cec/platform/cec-gpio/cec-gpio.c | 10 +---------
 include/media/cec.h                            | 11 +++++++----
 6 files changed, 69 insertions(+), 37 deletions(-)

Comments

Jenkins July 19, 2023, 12:16 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/c59cff3f-bdba-7f84-74d1-26b37d6cbeeb@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/324530/
Build time: 00:28:59
Link: https://lore.kernel.org/linux-media/c59cff3f-bdba-7f84-74d1-26b37d6cbeeb@xs4all.nl

gpg: Signature made Wed 19 Jul 2023 11:33:00 AM UTC
gpg:                using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: got 2/7 patches with issues, being 2 at build time

Error/warnings:

patches/0001-media-cec-core-add-adap_nb_transmit_canceled-callbac.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	SPARSE:../drivers/staging/media/tegra-video/vip.c ../drivers/staging/media/tegra-video/vip.c:280:24: warning: symbol 'tegra_vip_driver' was not declared. Should it be static?
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:476 ov2680_init_cfg() error: we previously assumed 'sd_state' could be null (see line 468)
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:524 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:447 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_fops.c: ../drivers/staging/media/atomisp/pci/atomisp_fops.c:517 atomisp_open() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2801 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2900 atomisp_cp_morph_table() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:4283 atomisp_set_fmt_to_snr() warn: variable dereferenced before check 'asd' (see line 4268)

    allyesconfig: return code #0:
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17: error: incompatible types in conditional expression (different base types):
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17:    void
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17:    int
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:475 ub913_log_status() error: uninitialized symbol 'v'.
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:479 ub913_log_status() error: uninitialized symbol 'v1'.
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:479 ub913_log_status() error: uninitialized symbol 'v2'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.
	../drivers/media/i2c/ds90ub960.c: ../drivers/media/i2c/ds90ub960.c:1780 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.
	../drivers/media/platform/mediatek/vcodec/vdec_msg_queue.c: ../drivers/media/platform/mediatek/vcodec/vdec_msg_queue.c:348 vdec_msg_queue_init() warn: missing unwind goto?
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2772 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: OOM: 3000004Kb sm_state_count = 1970928
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 54 seconds
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting

   checkpatch.pl:
	$ cat patches/0001-media-cec-core-add-adap_nb_transmit_canceled-callbac.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:27: WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

patches/0002-media-cec-core-add-adap_unconfigured-callback.patch:

    allyesconfig: return code #0:
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17: error: incompatible types in conditional expression (different base types):
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17:    void
	SPARSE:../drivers/media/cec/core/cec-adap.c ../drivers/media/cec/core/cec-adap.c:389:17:    int