| Message ID | 20230722-upstream-beaglev-ahead-dts-v1-1-ccda511357f4@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] riscv: dts: thead: add BeagleV Ahead board device tree | expand |
Reviewed-by: Guo Ren <guoren@kernel.org> On Sun, Jul 23, 2023 at 5:56 AM Drew Fustini <dfustini@baylibre.com> wrote: > > The BeagleV Ahead single board computer uses the T-Head TH1520 SoC. > Add a minimal device tree to support basic uart/gpio/dmac drivers so > that a user can boot to a basic shell. > > Link: https://beagleboard.org/beaglev-ahead > Signed-off-by: Drew Fustini <dfustini@baylibre.com> > --- > arch/riscv/boot/dts/thead/Makefile | 2 +- > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 61 ++++++++++++++++++++++ > 2 files changed, 62 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/thead/Makefile b/arch/riscv/boot/dts/thead/Makefile > index e311fc9a5939..b55a17127c2b 100644 > --- a/arch/riscv/boot/dts/thead/Makefile > +++ b/arch/riscv/boot/dts/thead/Makefile > @@ -1,2 +1,2 @@ > # SPDX-License-Identifier: GPL-2.0 > -dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb > +dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb th1520-beaglev-ahead.dtb > diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > new file mode 100644 > index 000000000000..c315e5bd3d2d > --- /dev/null > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > @@ -0,0 +1,61 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org> > + * Copyright (C) 2023 Drew Fustini <dfustini@baylibre.com> > + */ > + > +/dts-v1/; > + > +#include "th1520.dtsi" > + > +/ { > + model = "BeagleV Ahead"; > + compatible = "beagle,beaglev-ahead", "thead,th1520"; > + > + aliases { > + gpio0 = &gpio0; > + gpio1 = &gpio1; > + gpio2 = &gpio2; > + gpio3 = &gpio3; > + serial0 = &uart0; > + serial1 = &uart1; > + serial2 = &uart2; > + serial3 = &uart3; > + serial4 = &uart4; > + serial5 = &uart5; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x00000000 0x1 0x00000000>; > + > + }; > +}; > + > +&osc { > + clock-frequency = <24000000>; > +}; > + > +&osc_32k { > + clock-frequency = <32768>; > +}; > + > +&apb_clk { > + clock-frequency = <62500000>; > +}; > + > +&uart_sclk { > + clock-frequency = <100000000>; > +}; > + > +&dmac0 { > + status = "okay"; > +}; > + > +&uart0 { > + status = "okay"; > +}; > > -- > 2.34.1 >
On Mon, Jul 24, 2023 at 08:23:22AM +0800, Jisheng Zhang wrote: > On Sun, Jul 23, 2023 at 10:29:57AM -0700, Drew Fustini wrote: > > On Sun, Jul 23, 2023 at 11:32:17AM +0100, Conor Dooley wrote: > > > On Sat, Jul 22, 2023 at 02:55:39PM -0700, Drew Fustini wrote: > > > > > > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > @@ -0,0 +1,61 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > Hmm, should this not be dual licensed? > > > I notice the other th1520 stuff isn't either.. > > > > Good point, I'll resubmit with a dual license. > > > > Jisheng: are you okay with the other arch/riscv/boot/dts/thead files > > changing to a dual license? > > When cooking the initial patch, I wrote the lpi4a dts files from > scratch based on sipeed opened sch file, and currently only I made > contributions to them, so it's easy to make the lpi4a dts files > dual license. > > However, when constructing the th1520.dtsi, I refered the T-HEAD's > opensourced yocto repo(in fact, that's the only sourcecode/doc I have > at that time), and the license there is GPL-2.0. That's > also the reason why copyright of Alibaba Group Holding Limited is > added to th1520.dtsi. I'm not sure how to make th1520.dtsi dual > license. At least, this needs help from Guo Ren. Any suggestion is > appreciated. I think Guo Ren Acking the change should be sufficient. It'd be good to have them dual licensed to make it easier for other projects to include the dts files from Linux. Almost all of what we have at the moment is dual licensed, other than the Canaan stuff & some board dts files I got from customers that were only GPLed.
On Mon, Jul 24, 2023 at 6:38 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > On Mon, Jul 24, 2023 at 08:23:22AM +0800, Jisheng Zhang wrote: > > On Sun, Jul 23, 2023 at 10:29:57AM -0700, Drew Fustini wrote: > > > On Sun, Jul 23, 2023 at 11:32:17AM +0100, Conor Dooley wrote: > > > > On Sat, Jul 22, 2023 at 02:55:39PM -0700, Drew Fustini wrote: > > > > > > > > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > > @@ -0,0 +1,61 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > > > Hmm, should this not be dual licensed? > > > > I notice the other th1520 stuff isn't either.. > > > > > > Good point, I'll resubmit with a dual license. > > > > > > Jisheng: are you okay with the other arch/riscv/boot/dts/thead files > > > changing to a dual license? > > > > When cooking the initial patch, I wrote the lpi4a dts files from > > scratch based on sipeed opened sch file, and currently only I made > > contributions to them, so it's easy to make the lpi4a dts files > > dual license. > > > > However, when constructing the th1520.dtsi, I refered the T-HEAD's > > opensourced yocto repo(in fact, that's the only sourcecode/doc I have > > at that time), and the license there is GPL-2.0. That's > > also the reason why copyright of Alibaba Group Holding Limited is > > added to th1520.dtsi. I'm not sure how to make th1520.dtsi dual > > license. At least, this needs help from Guo Ren. Any suggestion is > > appreciated. > > I think Guo Ren Acking the change should be sufficient. It'd be good to > have them dual licensed to make it easier for other projects to include > the dts files from Linux. Almost all of what we have at the moment is > dual licensed, other than the Canaan stuff & some board dts files I got > from customers that were only GPLed. Yes, dual license is okay for us.
> On Sun, Jul 23, 2023 at 10:29:57AM -0700, Drew Fustini wrote: > > On Sun, Jul 23, 2023 at 11:32:17AM +0100, Conor Dooley wrote: > > > On Sat, Jul 22, 2023 at 02:55:39PM -0700, Drew Fustini wrote: > > > > > > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > @@ -0,0 +1,61 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > Hmm, should this not be dual licensed? > > > I notice the other th1520 stuff isn't either.. > > > > Good point, I'll resubmit with a dual license. > > > > Jisheng: are you okay with the other arch/riscv/boot/dts/thead files > > changing to a dual license? > > When cooking the initial patch, I wrote the lpi4a dts files from > scratch based on sipeed opened sch file, and currently only I made > contributions to them, so it's easy to make the lpi4a dts files > dual license. Thanks for your work. Is there any datasheet or user manual can get on public? I'm going to contribute drivers in my spare time, but it's hard to know the register file and dma information. > However, when constructing the th1520.dtsi, I refered the T-HEAD's > opensourced yocto repo(in fact, that's the only sourcecode/doc I have > at that time), and the license there is GPL-2.0. That's > also the reason why copyright of Alibaba Group Holding Limited is > added to th1520.dtsi. I'm not sure how to make th1520.dtsi dual > license. At least, this needs help from Guo Ren. Any suggestion is > appreciated. > > > > > > > > > > > > > + memory@0 { > > > > + device_type = "memory"; > > > > + reg = <0x0 0x00000000 0x1 0x00000000>; > > > > > > There's some extra spaces in here for some reason. > > > > Thanks for spotting that. I'll fix when I resubmit with dual licnese. > > > > Drew Kwang
On Thu, Jul 27, 2023 at 06:55:37PM +0900, Kwanghoon Son wrote: > > On Sun, Jul 23, 2023 at 10:29:57AM -0700, Drew Fustini wrote: > > > On Sun, Jul 23, 2023 at 11:32:17AM +0100, Conor Dooley wrote: > > > > On Sat, Jul 22, 2023 at 02:55:39PM -0700, Drew Fustini wrote: > > > > > > > > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > > @@ -0,0 +1,61 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > > > Hmm, should this not be dual licensed? > > > > I notice the other th1520 stuff isn't either.. > > > > > > Good point, I'll resubmit with a dual license. > > > > > > Jisheng: are you okay with the other arch/riscv/boot/dts/thead files > > > changing to a dual license? > > > > When cooking the initial patch, I wrote the lpi4a dts files from > > scratch based on sipeed opened sch file, and currently only I made > > contributions to them, so it's easy to make the lpi4a dts files > > dual license. > > Thanks for your work. > Is there any datasheet or user manual can get on public? > I'm going to contribute drivers in my spare time, > but it's hard to know the register file and dma information. We (the BeagleBoard.org Foundation) have asked T-Head to publish public documentation for the TH1520. It is our understanduing that this should happen soon but we do not know exactly when. I'll followup in the this thread once that happens. Thanks, Drew
diff --git a/arch/riscv/boot/dts/thead/Makefile b/arch/riscv/boot/dts/thead/Makefile index e311fc9a5939..b55a17127c2b 100644 --- a/arch/riscv/boot/dts/thead/Makefile +++ b/arch/riscv/boot/dts/thead/Makefile @@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0 -dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb +dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb th1520-beaglev-ahead.dtb diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts new file mode 100644 index 000000000000..c315e5bd3d2d --- /dev/null +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts @@ -0,0 +1,61 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org> + * Copyright (C) 2023 Drew Fustini <dfustini@baylibre.com> + */ + +/dts-v1/; + +#include "th1520.dtsi" + +/ { + model = "BeagleV Ahead"; + compatible = "beagle,beaglev-ahead", "thead,th1520"; + + aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + serial0 = &uart0; + serial1 = &uart1; + serial2 = &uart2; + serial3 = &uart3; + serial4 = &uart4; + serial5 = &uart5; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x00000000 0x1 0x00000000>; + + }; +}; + +&osc { + clock-frequency = <24000000>; +}; + +&osc_32k { + clock-frequency = <32768>; +}; + +&apb_clk { + clock-frequency = <62500000>; +}; + +&uart_sclk { + clock-frequency = <100000000>; +}; + +&dmac0 { + status = "okay"; +}; + +&uart0 { + status = "okay"; +};
The BeagleV Ahead single board computer uses the T-Head TH1520 SoC. Add a minimal device tree to support basic uart/gpio/dmac drivers so that a user can boot to a basic shell. Link: https://beagleboard.org/beaglev-ahead Signed-off-by: Drew Fustini <dfustini@baylibre.com> --- arch/riscv/boot/dts/thead/Makefile | 2 +- arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 61 ++++++++++++++++++++++ 2 files changed, 62 insertions(+), 1 deletion(-)