| Message ID | 20230726083808.140780-13-takahiro.akashi@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | firmware: scmi: add SCMI base protocol support | expand |
On Wed, 26 Jul 2023 at 02:40, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote: > > In this test, "scmi" command is tested against different sub-commands. > Please note that scmi command is for debug purpose and is not intended > in production system. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > v2 > * use helper functions, removing direct uses of ops > --- > test/dm/scmi.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 56 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
> From: AKASHI Takahiro <takahiro.akashi@linaro.org> > Sent: Wednesday, July 26, 2023 10:38 > > In this test, "scmi" command is tested against different sub-commands. > Please note that scmi command is for debug purpose and is not intended > in production system. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > v2 > * use helper functions, removing direct uses of ops Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> with patch on dm_test_scmi_base() squashed in patch 9/12. > --- > test/dm/scmi.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 56 insertions(+), 3 deletions(-) > > diff --git a/test/dm/scmi.c b/test/dm/scmi.c > index 41d46548f7fd..a3e61355088a 100644 > --- a/test/dm/scmi.c > +++ b/test/dm/scmi.c > @@ -134,9 +134,9 @@ static int dm_test_scmi_base(struct unit_test_state *uts) > ut_asserteq_str(priv->vendor, vendor); > > /* message attributes */ > - ret = scmi_protocol_message_attrs(base, > - SCMI_BASE_DISCOVER_SUB_VENDOR, > - &attributes); > + ret = scmi_base_protocol_message_attrs(base, > + SCMI_BASE_DISCOVER_SUB_VENDOR, > + &attributes); > ut_assertok(ret); > ut_assertok(attributes); > > @@ -204,6 +204,59 @@ static int dm_test_scmi_base(struct unit_test_state *uts) > > DM_TEST(dm_test_scmi_base, UT_TESTF_SCAN_FDT); > > +static int dm_test_scmi_cmd(struct unit_test_state *uts) > +{ > + struct udevice *agent_dev; > + > + /* preparation */ > + ut_assertok(uclass_get_device_by_name(UCLASS_SCMI_AGENT, "scmi", > + &agent_dev)); > + ut_assertnonnull(agent_dev); > + > + /* scmi info */ > + ut_assertok(run_command("scmi info", 0)); > + > + ut_assert_nextline("SCMI device: scmi"); > + ut_assert_nextline(" protocol version: 0x20000"); > + ut_assert_nextline(" # of agents: 2"); > + ut_assert_nextline(" 0: platform"); > + ut_assert_nextline(" > 1: OSPM"); > + ut_assert_nextline(" # of protocols: 3"); > + ut_assert_nextline(" Clock management"); > + ut_assert_nextline(" Reset domain management"); > + ut_assert_nextline(" Voltage domain management"); > + ut_assert_nextline(" vendor: U-Boot"); > + ut_assert_nextline(" sub vendor: Sandbox"); > + ut_assert_nextline(" impl version: 0x1"); > + > + ut_assert_console_end(); > + > + /* scmi perm_dev */ > + ut_assertok(run_command("scmi perm_dev 1 0 1", 0)); > + ut_assert_console_end(); > + > + ut_assert(run_command("scmi perm_dev 1 0 0", 0)); > + ut_assert_nextline("Denying access to device:0 failed (-13)"); > + ut_assert_console_end(); > + > + /* scmi perm_proto */ > + ut_assertok(run_command("scmi perm_proto 1 0 14 1", 0)); > + ut_assert_console_end(); > + > + ut_assert(run_command("scmi perm_proto 1 0 14 0", 0)); > + ut_assert_nextline("Denying access to protocol:0x14 on device:0 failed (-13)"); > + ut_assert_console_end(); > + > + /* scmi reset */ > + ut_assert(run_command("scmi reset 1 1", 0)); > + ut_assert_nextline("Reset failed (-13)"); > + ut_assert_console_end(); > + > + return 0; > +} > + > +DM_TEST(dm_test_scmi_cmd, UT_TESTF_SCAN_FDT); > + > static int dm_test_scmi_clocks(struct unit_test_state *uts) > { > struct sandbox_scmi_agent *agent; > -- > 2.41.0 >
diff --git a/test/dm/scmi.c b/test/dm/scmi.c index 41d46548f7fd..a3e61355088a 100644 --- a/test/dm/scmi.c +++ b/test/dm/scmi.c @@ -134,9 +134,9 @@ static int dm_test_scmi_base(struct unit_test_state *uts) ut_asserteq_str(priv->vendor, vendor); /* message attributes */ - ret = scmi_protocol_message_attrs(base, - SCMI_BASE_DISCOVER_SUB_VENDOR, - &attributes); + ret = scmi_base_protocol_message_attrs(base, + SCMI_BASE_DISCOVER_SUB_VENDOR, + &attributes); ut_assertok(ret); ut_assertok(attributes); @@ -204,6 +204,59 @@ static int dm_test_scmi_base(struct unit_test_state *uts) DM_TEST(dm_test_scmi_base, UT_TESTF_SCAN_FDT); +static int dm_test_scmi_cmd(struct unit_test_state *uts) +{ + struct udevice *agent_dev; + + /* preparation */ + ut_assertok(uclass_get_device_by_name(UCLASS_SCMI_AGENT, "scmi", + &agent_dev)); + ut_assertnonnull(agent_dev); + + /* scmi info */ + ut_assertok(run_command("scmi info", 0)); + + ut_assert_nextline("SCMI device: scmi"); + ut_assert_nextline(" protocol version: 0x20000"); + ut_assert_nextline(" # of agents: 2"); + ut_assert_nextline(" 0: platform"); + ut_assert_nextline(" > 1: OSPM"); + ut_assert_nextline(" # of protocols: 3"); + ut_assert_nextline(" Clock management"); + ut_assert_nextline(" Reset domain management"); + ut_assert_nextline(" Voltage domain management"); + ut_assert_nextline(" vendor: U-Boot"); + ut_assert_nextline(" sub vendor: Sandbox"); + ut_assert_nextline(" impl version: 0x1"); + + ut_assert_console_end(); + + /* scmi perm_dev */ + ut_assertok(run_command("scmi perm_dev 1 0 1", 0)); + ut_assert_console_end(); + + ut_assert(run_command("scmi perm_dev 1 0 0", 0)); + ut_assert_nextline("Denying access to device:0 failed (-13)"); + ut_assert_console_end(); + + /* scmi perm_proto */ + ut_assertok(run_command("scmi perm_proto 1 0 14 1", 0)); + ut_assert_console_end(); + + ut_assert(run_command("scmi perm_proto 1 0 14 0", 0)); + ut_assert_nextline("Denying access to protocol:0x14 on device:0 failed (-13)"); + ut_assert_console_end(); + + /* scmi reset */ + ut_assert(run_command("scmi reset 1 1", 0)); + ut_assert_nextline("Reset failed (-13)"); + ut_assert_console_end(); + + return 0; +} + +DM_TEST(dm_test_scmi_cmd, UT_TESTF_SCAN_FDT); + static int dm_test_scmi_clocks(struct unit_test_state *uts) { struct sandbox_scmi_agent *agent;