| Message ID | 20230728065739.580281-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | leds: qcom-lpg: Drop assignment to struct pwmchip::base | expand |
On Fri, 28 Jul 2023 08:57:39 +0200, Uwe Kleine-König wrote: > Since commit f9a8ee8c8bcd ("pwm: Always allocate PWM chip base ID > dynamically") there is no effect any more for assigning this variable. See > pwmchip_add() which unconditionally overwrites this member. > > Applied, thanks! [1/1] leds: qcom-lpg: Drop assignment to struct pwmchip::base commit: 841165267827955bb3295b066cb6a906ba9265c0 -- Lee Jones [李琼斯]
diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c index 59581b3e25ca..c2fc768eaf87 100644 --- a/drivers/leds/rgb/leds-qcom-lpg.c +++ b/drivers/leds/rgb/leds-qcom-lpg.c @@ -1093,7 +1093,6 @@ static int lpg_add_pwm(struct lpg *lpg) { int ret; - lpg->pwm.base = -1; lpg->pwm.dev = lpg->dev; lpg->pwm.npwm = lpg->num_channels; lpg->pwm.ops = &lpg_pwm_ops;
Since commit f9a8ee8c8bcd ("pwm: Always allocate PWM chip base ID dynamically") there is no effect any more for assigning this variable. See pwmchip_add() which unconditionally overwrites this member. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, this is the last driver setting .base. Would be great to get rid of that, as I might want to drop .base from the pwm core. Thanks for considering, Uwe drivers/leds/rgb/leds-qcom-lpg.c | 1 - 1 file changed, 1 deletion(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5