| Message ID | 20230803092933.720749-1-ruanjinjie@huawei.com |
|---|---|
| State | Accepted |
| Commit | 7999b615fd18e2c2d1aa540b930341c494c0c3e7 |
| Headers | show |
| Series | [-next] crypto: hisilicon/sec - Do not check for 0 return after calling platform_get_irq() | expand |
On Thu, Aug 03, 2023 at 05:29:33PM +0800, Ruan Jinjie wrote: > Since commit ce753ad1549c ("platform: finally disallow IRQ0 in > platform_get_irq() and its ilk"), there is no possible for > platform_get_irq() to return 0. Use the return value > from platform_get_irq(). > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/crypto/hisilicon/sec/sec_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/sec/sec_drv.c b/drivers/crypto/hisilicon/sec/sec_drv.c index e75851326c1e..e1e08993de12 100644 --- a/drivers/crypto/hisilicon/sec/sec_drv.c +++ b/drivers/crypto/hisilicon/sec/sec_drv.c @@ -1107,8 +1107,8 @@ static int sec_queue_res_cfg(struct sec_queue *queue) } queue->task_irq = platform_get_irq(to_platform_device(dev), queue->queue_id * 2 + 1); - if (queue->task_irq <= 0) { - ret = -EINVAL; + if (queue->task_irq < 0) { + ret = queue->task_irq; goto err_free_ring_db; }
Since commit ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq() and its ilk"), there is no possible for platform_get_irq() to return 0. Use the return value from platform_get_irq(). Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/crypto/hisilicon/sec/sec_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)