| Message ID | 20230804105226.3022473-1-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] media: ivsc: Improve Kconfig help text | expand |
Hi Laurent, On Fri, Aug 04, 2023 at 04:48:25PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Aug 04, 2023 at 01:52:26PM +0300, Sakari Ailus wrote: > > Improve the Kconfig help text to convey the ACE is for changing camera > > sensor ownership and CSI for configuring the CSI-2 rx and tx. > > > > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > --- > > drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig > > index 9535ac10f4f7..e9d94dbb4305 100644 > > --- a/drivers/media/pci/intel/ivsc/Kconfig > > +++ b/drivers/media/pci/intel/ivsc/Kconfig > > @@ -8,5 +8,9 @@ config INTEL_VSC > > This adds support for Intel Visual Sensing Controller (IVSC). > > > > Enables the IVSC firmware services required for controlling > > - camera sensor ownership and CSI-2 link through Image Processing > > - Unit(IPU) driver of Intel. > > + camera sensor ownership between IVSC and host CPU (ACE) as well > > What does ACE stand for ? > > > + as configuring the CSI-2 link (CSI) towards the Image Processing > > + Unit (IPU) driver of Intel. > > If I understand things correctly, this is about routing the data from > the sensor to the IVSC output towards the host. Is that right ? If so, > let's make that explicit. Yes, I'll add that for v2. > > > + > > + The modules will be called ivsc-csi and ivsc-ace. > > + >
diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig index 9535ac10f4f7..e9d94dbb4305 100644 --- a/drivers/media/pci/intel/ivsc/Kconfig +++ b/drivers/media/pci/intel/ivsc/Kconfig @@ -8,5 +8,9 @@ config INTEL_VSC This adds support for Intel Visual Sensing Controller (IVSC). Enables the IVSC firmware services required for controlling - camera sensor ownership and CSI-2 link through Image Processing - Unit(IPU) driver of Intel. + camera sensor ownership between IVSC and host CPU (ACE) as well + as configuring the CSI-2 link (CSI) towards the Image Processing + Unit (IPU) driver of Intel. + + The modules will be called ivsc-csi and ivsc-ace. +
Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)