diff mbox series

[for-8.1] tests/tcg: Disable filename test for info proc mappings

Message ID 20230808234958.148910-1-richard.henderson@linaro.org
State Superseded
Headers show
Series [for-8.1] tests/tcg: Disable filename test for info proc mappings | expand

Commit Message

Richard Henderson Aug. 8, 2023, 11:49 p.m. UTC
This test fails when host page size != guest page size,
because qemu may not be able to directly map the file.

Fixes: a6341482695 ("tests/tcg: Add a test for info proc mappings")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tests/tcg/multiarch/gdbstub/test-proc-mappings.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ilya Leoshkevich Aug. 9, 2023, 10:59 a.m. UTC | #1
On Tue, 2023-08-08 at 16:49 -0700, Richard Henderson wrote:
> This test fails when host page size != guest page size,
> because qemu may not be able to directly map the file.
> 
> Fixes: a6341482695 ("tests/tcg: Add a test for info proc mappings")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tests/tcg/multiarch/gdbstub/test-proc-mappings.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> index 7b596ac21b..5e3e5a2fb7 100644
> --- a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> +++ b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> @@ -33,7 +33,8 @@ def run_test():
>              return
>          raise
>      report(isinstance(mappings, str), "Fetched the mappings from the
> inferior")
> -    report("/sha1" in mappings, "Found the test binary name in the
> mappings")
> +    # Broken with host page size > guest page size
> +    # report("/sha1" in mappings, "Found the test binary name in the
> mappings")
>  
>  
>  def main():

I'll try to find a way to check host/guest page sizes in Python for
8.2. I think it's fine to disable the check for 8.1.

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
diff mbox series

Patch

diff --git a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
index 7b596ac21b..5e3e5a2fb7 100644
--- a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
+++ b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
@@ -33,7 +33,8 @@  def run_test():
             return
         raise
     report(isinstance(mappings, str), "Fetched the mappings from the inferior")
-    report("/sha1" in mappings, "Found the test binary name in the mappings")
+    # Broken with host page size > guest page size
+    # report("/sha1" in mappings, "Found the test binary name in the mappings")
 
 
 def main():