| Message ID | 20230807213022.1862903-3-florian.fainelli@broadcom.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: bcm: Use dev_err_probe() | expand |
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c index 5045a7e57f1d..e32901a92fcf 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(dev, gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; }
We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)