| Message ID | 20230808091625.12760-2-ilpo.jarvinen@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/resctrl: Rework benchmark command handling | expand |
Hi Ilpo, On 8/15/2023 11:32 PM, Ilpo Järvinen wrote: > Ah sorry, it is actually scripts/get_maintainer.pl automation I use with > git send-email to figure out where to send the patches besides the --to & > --cc entries I provided. For this patch, get_maintainer.pl returns this > list: > > Fenghua Yu <fenghua.yu@intel.com> (supporter:RDT - RESOURCE ALLOCATION,blamed_fixes:1/1=100%) > Reinette Chatre <reinette.chatre@intel.com> (supporter:RDT - RESOURCE ALLOCATION) > Shuah Khan <shuah@kernel.org> (maintainer:KERNEL SELFTEST FRAMEWORK,blamed_fixes:1/1=100%) > Babu Moger <babu.moger@amd.com> (blamed_fixes:1/1=100%) > Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> (blamed_fixes:1/1=100%) > linux-kernel@vger.kernel.org (open list:RDT - RESOURCE ALLOCATION) > linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK) > > ...which includes Sai's address (not much I can do about that, it's > immutably crafted into git history that those lines were once touched by > Sai). I've thought of writing yet another wrapper to filter out known > failing addresses but until that's done, either I need to (remember to) > manually send the series w/o get_maintainer.pl automation or accept a few > failures here and there. > You can append Sai's address to .get_maintainer.ignore. Reinette
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c index d511daeb6851..eef9e02516ad 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -255,6 +255,9 @@ int main(int argc, char **argv) return ksft_exit_skip("Not running as root. Skipping...\n"); if (has_ben) { + if (argc - ben_ind >= BENCHMARK_ARGS - 1) + ksft_exit_fail_msg("Too long benchmark command"); + /* Extract benchmark command from command line. */ for (i = ben_ind; i < argc; i++) { benchmark_cmd[i - ben_ind] = benchmark_cmd_area[i];
Benchmark command is copied into an array in the stack. The array is BENCHMARK_ARGS items long but the command line could try to provide a longer command. Return error in case the benchmark command does not fit to its array. Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test") Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- tools/testing/selftests/resctrl/resctrl_tests.c | 3 +++ 1 file changed, 3 insertions(+)