| Message ID | 20230815-aw2013-vio-v3-2-2505296b0856@gerhold.net |
|---|---|
| State | New |
| Headers | show |
| Series | leds: aw2013: Document interrupt and pull-up supply | expand |
On 15/08/2023 19:21, Stephan Gerhold wrote: > Since the interrupt and I2C lines of AW2013 operate in open drain low > active mode a pull-up supply is needed for correct operation. > Unfortunately there is no ideal place to describe it in the DT: The > pull-up needed for the I2C lines could be described on the I2C bus. > However, the pull-up needed for the interrupt line belongs neither > directly to the interrupt controller nor to AW2013. Since the AW2013 > driver will be typically in control of the power management and > interrupt masking it makes more sense to describe it inside the AW2013 > device tree node. > > Add it to the AW2013 DT schema together with a comment that makes it > clear what exactly it represents. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml index a0a0dabcfbf3..26238446f2bd 100644 --- a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml +++ b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml @@ -28,6 +28,12 @@ properties: vcc-supply: description: Regulator providing power to the "VCC" pin. + vio-supply: + description: Regulator providing power for pull-up of the I/O lines. + "VIO1" in the typical application circuit example of the datasheet. + Note that this regulator does not directly connect to AW2013, but is + needed for the correct operation of the interrupt and I2C lines. + "#address-cells": const: 1
Since the interrupt and I2C lines of AW2013 operate in open drain low active mode a pull-up supply is needed for correct operation. Unfortunately there is no ideal place to describe it in the DT: The pull-up needed for the I2C lines could be described on the I2C bus. However, the pull-up needed for the interrupt line belongs neither directly to the interrupt controller nor to AW2013. Since the AW2013 driver will be typically in control of the power management and interrupt masking it makes more sense to describe it inside the AW2013 device tree node. Add it to the AW2013 DT schema together with a comment that makes it clear what exactly it represents. Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- Related previous discussion: https://lore.kernel.org/linux-leds/20230321220825.GA1685482-robh@kernel.org/ --- Documentation/devicetree/bindings/leds/leds-aw2013.yaml | 6 ++++++ 1 file changed, 6 insertions(+)