| Message ID | 20230831201429.94554-3-biju.das.jz@bp.renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Match data improvements for wm8580 driver | expand |
On Thu, Aug 31, 2023 at 09:14:29PM +0100, Biju Das wrote:
> Move OF table near to the user.
It does a bit more that that.
Hi Andy, > Subject: Re: [PATCH v3 2/2] ASoC: wm8580: Move OF table > > On Thu, Aug 31, 2023 at 09:14:29PM +0100, Biju Das wrote: > > Move OF table near to the user. > > It does a bit more that that. OK I will send separate patch for removing trailing comma in terminator. Cheers, Biju
On Fri, Sep 01, 2023 at 06:33:08AM +0000, Biju Das wrote: > Hi Andy, > > > Subject: Re: [PATCH v3 2/2] ASoC: wm8580: Move OF table > > > > On Thu, Aug 31, 2023 at 09:14:29PM +0100, Biju Das wrote: > > > Move OF table near to the user. > > > > It does a bit more that that. > > OK I will send separate patch for removing trailing comma > in terminator. It's fine to have them in a single patch as they are kinda related (since you touch the lines anyway). My point is that this change also needs to be described in the commit message.
diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index 826c39ec4a1e..28c0ba348634 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -988,13 +988,6 @@ static const struct wm8580_driver_data wm8581_data = { .num_dacs = 4, }; -static const struct of_device_id wm8580_of_match[] = { - { .compatible = "wlf,wm8580", .data = &wm8580_data }, - { .compatible = "wlf,wm8581", .data = &wm8581_data }, - { }, -}; -MODULE_DEVICE_TABLE(of, wm8580_of_match); - static int wm8580_i2c_probe(struct i2c_client *i2c) { struct wm8580_priv *wm8580; @@ -1031,6 +1024,13 @@ static int wm8580_i2c_probe(struct i2c_client *i2c) return ret; } +static const struct of_device_id wm8580_of_match[] = { + { .compatible = "wlf,wm8580", .data = &wm8580_data }, + { .compatible = "wlf,wm8581", .data = &wm8581_data }, + { } +}; +MODULE_DEVICE_TABLE(of, wm8580_of_match); + static const struct i2c_device_id wm8580_i2c_id[] = { { "wm8580", (kernel_ulong_t)&wm8580_data }, { "wm8581", (kernel_ulong_t)&wm8581_data },
Move OF table near to the user. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v2: * New patch. --- sound/soc/codecs/wm8580.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)