[1/3] mfd: Provide MACRO to declare commonly defined MFD cell attributes

Message ID 20160713112651.14539-2-lee.jones@linaro.org
State New
Headers show

Commit Message

Lee Jones July 13, 2016, 11:26 a.m.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 include/linux/mfd/core.h | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

-- 
2.9.0

Comments

Lee Jones July 18, 2016, 1:25 p.m. | #1
On Fri, 15 Jul 2016, Laxman Dewangan wrote:

> 

> On Wednesday 13 July 2016 04:56 PM, Lee Jones wrote:

> > Cc: Laxman Dewangan <ldewangan@nvidia.com>

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > ---

> >   include/linux/mfd/core.h | 29 +++++++++++++++++++++++++++++

> >   1 file changed, 29 insertions(+)

> > 

> > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h

> > index 99c0395..c6018f4 100644

> > --- a/include/linux/mfd/core.h

> > +++ b/include/linux/mfd/core.h

> > @@ -16,6 +16,35 @@

> >   #include <linux/platform_device.h>

> 

> > +#define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id)		\

> > +	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL)	\

> > +

> > +#define MFD_CELL_RES(_name, _res)					\

> > +	MFD_CELL_ALL(_name, _res, _pdata, 0, 0, NULL, NULL)		\

> > +

> Here _pdata should not be used. Instead it should be NULL.


Yes, it should.  Thanks for the review.

> I corrected it locally and then compiled and teste.


Wonderful, thanks.

> Once above fixed, you can take my ack and tested by

> 

> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

> Tested-by: Laxman Dewangan <ldewangan@nvidia.com>

> 


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch hide | download patch | download mbox

diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index 99c0395..c6018f4 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -16,6 +16,35 @@ 
 
 #include <linux/platform_device.h>
 
+#define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource))
+
+#define MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, _match)\
+	{								\
+		.name = (_name),					\
+		.resources = (_res),					\
+		.num_resources = MFD_RES_SIZE((_res)),			\
+		.platform_data = (_pdata),				\
+		.pdata_size = (_pdsize),				\
+		.of_compatible = (_compat),				\
+		.acpi_match = (_match),					\
+		.id = (_id),						\
+	}
+
+#define OF_MFD_CELL(_name, _res, _pdata, _pdsize,_id, _compat)		\
+	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, NULL)	\
+
+#define ACPI_MFD_CELL(_name, _res, _pdata, _pdsize, _id, _match)	\
+	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, _match)	\
+
+#define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id)		\
+	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL)	\
+
+#define MFD_CELL_RES(_name, _res)					\
+	MFD_CELL_ALL(_name, _res, _pdata, 0, 0, NULL, NULL)		\
+
+#define MFD_CELL_NAME(_name)						\
+	MFD_CELL_ALL(_name, NULL, NULL, 0, 0, NULL, NULL)		\
+
 struct irq_domain;
 struct property_entry;