diff mbox series

[1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ8174 family

Message ID 20230901181041.1538999-1-robimarko@gmail.com
State Accepted
Commit b8c889bef9797a58b8b5aad23875cc4d04b3efd3
Headers show
Series [1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ8174 family | expand

Commit Message

Robert Marko Sept. 1, 2023, 6:10 p.m. UTC
IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
are missing so lets add them.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 include/dt-bindings/arm/qcom,ids.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Conor Dooley Sept. 2, 2023, 10:41 a.m. UTC | #1
On Fri, Sep 01, 2023 at 08:10:04PM +0200, Robert Marko wrote:
> IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> are missing so lets add them.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>  include/dt-bindings/arm/qcom,ids.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index be12e1dd1f38..d2b84a308fde 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -203,6 +203,9 @@
>  #define QCOM_ID_SM6125			394
>  #define QCOM_ID_IPQ8070A		395
>  #define QCOM_ID_IPQ8071A		396
> +#define QCOM_ID_IPQ8172			397
> +#define QCOM_ID_IPQ8173			398
> +#define QCOM_ID_IPQ8174			399
>  #define QCOM_ID_IPQ6018			402
>  #define QCOM_ID_IPQ6028			403
>  #define QCOM_ID_SDM429W			416
> -- 
> 2.41.0
>
Kathiravan Thirumoorthy Sept. 2, 2023, 2:42 p.m. UTC | #2
On 9/1/2023 11:40 PM, Robert Marko wrote:
> IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> are missing so lets add them.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>   include/dt-bindings/arm/qcom,ids.h | 3 +++
>   1 file changed, 3 insertions(+)


Reviewed-by: Kathiravan T <quic_kathirav@quicinc.com>


>
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index be12e1dd1f38..d2b84a308fde 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -203,6 +203,9 @@
>   #define QCOM_ID_SM6125			394
>   #define QCOM_ID_IPQ8070A		395
>   #define QCOM_ID_IPQ8071A		396
> +#define QCOM_ID_IPQ8172			397
> +#define QCOM_ID_IPQ8173			398
> +#define QCOM_ID_IPQ8174			399
>   #define QCOM_ID_IPQ6018			402
>   #define QCOM_ID_IPQ6028			403
>   #define QCOM_ID_SDM429W			416
Kathiravan Thirumoorthy Sept. 2, 2023, 2:43 p.m. UTC | #3
On 9/1/2023 11:40 PM, Robert Marko wrote:
> IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> are missing so lets add them.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>   drivers/soc/qcom/socinfo.c | 3 +++
>   1 file changed, 3 insertions(+)


Reviewed-by: Kathiravan T <quic_kathirav@quicinc.com>


>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 497cfb720fcb..345f0b002eb5 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -359,6 +359,9 @@ static const struct soc_id soc_id[] = {
>   	{ qcom_board_id(SM6125) },
>   	{ qcom_board_id(IPQ8070A) },
>   	{ qcom_board_id(IPQ8071A) },
> +	{ qcom_board_id(IPQ8172) },
> +	{ qcom_board_id(IPQ8173) },
> +	{ qcom_board_id(IPQ8174) },
>   	{ qcom_board_id(IPQ6018) },
>   	{ qcom_board_id(IPQ6028) },
>   	{ qcom_board_id(SDM429W) },
Dmitry Baryshkov Sept. 2, 2023, 3:35 p.m. UTC | #4
On Sat, 2 Sept 2023 at 17:43, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>
>
> On 9/1/2023 11:40 PM, Robert Marko wrote:
> > IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> > are missing so lets add them.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >   include/dt-bindings/arm/qcom,ids.h | 3 +++
> >   1 file changed, 3 insertions(+)
>
>
> Reviewed-by: Kathiravan T <quic_kathirav@quicinc.com>

Is there a chance of you using the full family name in your git tags?

> > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> > index be12e1dd1f38..d2b84a308fde 100644
> > --- a/include/dt-bindings/arm/qcom,ids.h
> > +++ b/include/dt-bindings/arm/qcom,ids.h
> > @@ -203,6 +203,9 @@
> >   #define QCOM_ID_SM6125                      394
> >   #define QCOM_ID_IPQ8070A            395
> >   #define QCOM_ID_IPQ8071A            396
> > +#define QCOM_ID_IPQ8172                      397
> > +#define QCOM_ID_IPQ8173                      398
> > +#define QCOM_ID_IPQ8174                      399
> >   #define QCOM_ID_IPQ6018                     402
> >   #define QCOM_ID_IPQ6028                     403
> >   #define QCOM_ID_SDM429W                     416
Kathiravan Thirumoorthy Sept. 4, 2023, 3:42 a.m. UTC | #5
On 9/2/2023 9:05 PM, Dmitry Baryshkov wrote:
> On Sat, 2 Sept 2023 at 17:43, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>>
>> On 9/1/2023 11:40 PM, Robert Marko wrote:
>>> IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
>>> are missing so lets add them.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>>    include/dt-bindings/arm/qcom,ids.h | 3 +++
>>>    1 file changed, 3 insertions(+)
>>
>> Reviewed-by: Kathiravan T <quic_kathirav@quicinc.com>
> Is there a chance of you using the full family name in your git tags?


Sure, Going forward will use the full family name..


Thanks,

>
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index be12e1dd1f38..d2b84a308fde 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -203,6 +203,9 @@
>>>    #define QCOM_ID_SM6125                      394
>>>    #define QCOM_ID_IPQ8070A            395
>>>    #define QCOM_ID_IPQ8071A            396
>>> +#define QCOM_ID_IPQ8172                      397
>>> +#define QCOM_ID_IPQ8173                      398
>>> +#define QCOM_ID_IPQ8174                      399
>>>    #define QCOM_ID_IPQ6018                     402
>>>    #define QCOM_ID_IPQ6028                     403
>>>    #define QCOM_ID_SDM429W                     416
>
>
Bjorn Andersson Sept. 14, 2023, 4:04 p.m. UTC | #6
On Fri, 01 Sep 2023 20:10:04 +0200, Robert Marko wrote:
> IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> are missing so lets add them.
> 
> 

Applied, thanks!

[1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ8174 family
      commit: b8c889bef9797a58b8b5aad23875cc4d04b3efd3
[2/2] soc: qcom: socinfo: Add IDs for IPQ8174 family
      commit: e9104e73d4fc8a023608be9c18ee1b897d0ccb14

Best regards,
diff mbox series

Patch

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index be12e1dd1f38..d2b84a308fde 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -203,6 +203,9 @@ 
 #define QCOM_ID_SM6125			394
 #define QCOM_ID_IPQ8070A		395
 #define QCOM_ID_IPQ8071A		396
+#define QCOM_ID_IPQ8172			397
+#define QCOM_ID_IPQ8173			398
+#define QCOM_ID_IPQ8174			399
 #define QCOM_ID_IPQ6018			402
 #define QCOM_ID_IPQ6028			403
 #define QCOM_ID_SDM429W			416