diff mbox

configure.ac: fix have_pcap AM_CONDITIONAL

Message ID 1468852846-11067-1-git-send-email-zoltan.kiss@linaro.org
State New
Headers show

Commit Message

Zoltan Kiss July 18, 2016, 2:40 p.m. UTC
This causes "./configure: line 20048: test: =: unary operator expected" error
messages, while the generated code was like this:

 if test $pktio_dpdk_support = yes ; then
  PKTIO_DPDK_TRUE=
  PKTIO_DPDK_FALSE='#'
else
...

Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>

---

Comments

Zoltan Kiss July 22, 2016, 3:20 p.m. UTC | #1
Ping

On 18/07/16 15:40, Zoltan Kiss wrote:
> This causes "./configure: line 20048: test: =: unary operator expected" error

> messages, while the generated code was like this:

>

>  if test $pktio_dpdk_support = yes ; then

>   PKTIO_DPDK_TRUE=

>   PKTIO_DPDK_FALSE='#'

> else

> ...

>

> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>

> ---

> diff --git a/configure.ac b/configure.ac

> index c0eb207..97310c4 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -163,7 +163,7 @@ AC_SUBST([testdir])

>  AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ])

>  AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes])

>  AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])

> -AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])

> +AM_CONDITIONAL([HAVE_PCAP], [test x$have_pcap = xyes])

>  AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"])

>  AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])

>  AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])

>
Mike Holmes July 22, 2016, 3:22 p.m. UTC | #2
On 18 July 2016 at 10:40, Zoltan Kiss <zoltan.kiss@linaro.org> wrote:

> This causes "./configure: line 20048: test: =: unary operator expected"

> error

> messages, while the generated code was like this:

>

>  if test $pktio_dpdk_support = yes ; then

>   PKTIO_DPDK_TRUE=

>   PKTIO_DPDK_FALSE='#'

> else

> ...

>

> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>

>


Reviewd-by: Mike Holmes <mike.holmes@linaro.org>


> ---

> diff --git a/configure.ac b/configure.ac

> index c0eb207..97310c4 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -163,7 +163,7 @@ AC_SUBST([testdir])

>  AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ])

>  AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes])

>  AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])

> -AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])

> +AM_CONDITIONAL([HAVE_PCAP], [test x$have_pcap = xyes])

>  AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"])

>  AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])

>  AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index c0eb207..97310c4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -163,7 +163,7 @@  AC_SUBST([testdir])
 AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ])
 AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes])
 AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])
-AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])
+AM_CONDITIONAL([HAVE_PCAP], [test x$have_pcap = xyes])
 AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"])
 AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])
 AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])