diff mbox series

[7/9] gitlab: make Cirrus CI jobs gating

Message ID 20230914155422.426639-8-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next: avocado, gitlab, docker, cirrus | expand

Commit Message

Alex Bennée Sept. 14, 2023, 3:54 p.m. UTC
From: Daniel P. Berrangé <berrange@redhat.com>

The Cirrus CI jobs have been non-gating for a while to let us build
confidence in their reliability. Aside from periodic dependancy
problems when FreeBSD Ports switches to be based on a new FreeBSD
image version, the jobs have been reliable. It is thus worth making
them gating to prevent build failures being missed during merges.

Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230912184130.3056054-5-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitlab-ci.d/cirrus.yml | 1 -
 1 file changed, 1 deletion(-)

Comments

Philippe Mathieu-Daudé Sept. 15, 2023, 9:15 a.m. UTC | #1
On 14/9/23 17:54, Alex Bennée wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
> 
> The Cirrus CI jobs have been non-gating for a while to let us build
> confidence in their reliability. Aside from periodic dependancy
> problems when FreeBSD Ports switches to be based on a new FreeBSD
> image version, the jobs have been reliable. It is thus worth making
> them gating to prevent build failures being missed during merges.
> 
> Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20230912184130.3056054-5-berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   .gitlab-ci.d/cirrus.yml | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
index 816d89cc2a..e7f1f83c2c 100644
--- a/.gitlab-ci.d/cirrus.yml
+++ b/.gitlab-ci.d/cirrus.yml
@@ -19,7 +19,6 @@ 
   # as there's often a 5-10 minute delay before Cirrus CI
   # actually starts the task
   timeout: 80m
-  allow_failure: true
   script:
     - source .gitlab-ci.d/cirrus/$NAME.vars
     - sed -e "s|[@]CI_REPOSITORY_URL@|$CI_REPOSITORY_URL|g"