[2/3] webkitgtk: Do not use gold with clang

Message ID 1dae681b38dac84b2febd93bdea237c8fc516c1f.1469043317.git.raj.khem@gmail.com
State Accepted
Commit 2a535deb4e080f464db1ffc40dfc53235fa13874
Headers show

Commit Message

Khem Raj July 20, 2016, 7:38 p.m.
clang cross compiler fails to detect gold linker from
cross-binutils, instead it defaults to ld.gold from build
host, lets disable using gold when clang is active to avoid
this issue

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj July 20, 2016, 7:40 p.m. | #1
> On Jul 20, 2016, at 12:38 PM, Khem Raj <raj.khem@gmail.com> wrote:

> 

> clang cross compiler fails to detect gold linker from

> cross-binutils, instead it defaults to ld.gold from build

> host, lets disable using gold when clang is active to avoid

> this issue

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

> meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 2 ++

> 1 file changed, 2 insertions(+)

> 

> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb

> index 28517c4..2e5a1e4 100644

> --- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb

> +++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb

> @@ -79,6 +79,8 @@ EXTRA_OECMAKE_append_armv7a = " -DENABLE_JIT=OFF "

> # binutils 2.25.1 has a bug on aarch64:

> # https://sourceware.org/bugzilla/show_bug.cgi?id=18430

> EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "

> +EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "

> +EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF “


redundant line. It has been fixed in pull tree.

> 

> # JIT not supported on MIPS either

> EXTRA_OECMAKE_append_mips = " -DENABLE_JIT=OFF "

> --

> 2.9.0

>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
index 28517c4..2e5a1e4 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
@@ -79,6 +79,8 @@  EXTRA_OECMAKE_append_armv7a = " -DENABLE_JIT=OFF "
 # binutils 2.25.1 has a bug on aarch64:
 # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
 EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
+EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "
+EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
 EXTRA_OECMAKE_append_mips = " -DENABLE_JIT=OFF "