| Message ID | 20230922-apq8016-sbc-camera-dtso-v1-1-ce9451895ca1@gerhold.net |
|---|---|
| State | Accepted |
| Commit | 0f893a2cb1ab7af6c88cfa1034debb6a790fb6c6 |
| Headers | show |
| Series | arm64: dts: qcom: apq8016-sbc-d3-camera: Convert to DT overlay | expand |
On 22/09/2023 16:11, Stephan Gerhold wrote: > Add "regulator" to the node names of the fixed regulators, and drop the > "_rear" part of the camera node name since it is not part of the class > of the device (which is simply "camera"). > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > &cci_i2c0 { > - camera_rear@3b { > + camera@3b { > compatible = "ovti,ov5640"; > reg = <0x3b>; You could consider a follow-up patch here along the lines of orientation = <2> to indicate the camera is External. This shows up with a pretty name in libcamera based applications then. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts index c08b4be5cc7e..f9cbf8c1d689 100644 --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts @@ -9,7 +9,7 @@ #include "apq8016-sbc.dts" / { - camera_vdddo_1v8: camera-vdddo-1v8 { + camera_vdddo_1v8: regulator-camera-vdddo { compatible = "regulator-fixed"; regulator-name = "camera_vdddo"; regulator-min-microvolt = <1800000>; @@ -17,7 +17,7 @@ camera_vdddo_1v8: camera-vdddo-1v8 { regulator-always-on; }; - camera_vdda_2v8: camera-vdda-2v8 { + camera_vdda_2v8: regulator-camera-vdda { compatible = "regulator-fixed"; regulator-name = "camera_vdda"; regulator-min-microvolt = <2800000>; @@ -25,7 +25,7 @@ camera_vdda_2v8: camera-vdda-2v8 { regulator-always-on; }; - camera_vddd_1v5: camera-vddd-1v5 { + camera_vddd_1v5: regulator-camera-vddd { compatible = "regulator-fixed"; regulator-name = "camera_vddd"; regulator-min-microvolt = <1500000>; @@ -53,7 +53,7 @@ &cci { }; &cci_i2c0 { - camera_rear@3b { + camera@3b { compatible = "ovti,ov5640"; reg = <0x3b>;
Add "regulator" to the node names of the fixed regulators, and drop the "_rear" part of the camera node name since it is not part of the class of the device (which is simply "camera"). Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)