diff mbox

[1/2] linux-gen: Makefile: Move EXTRA_DIST to to platform/Makefile.inc

Message ID 1469094125-9696-2-git-send-email-anders.roxell@linaro.org
State Superseded
Headers show

Commit Message

Anders Roxell July 21, 2016, 9:42 a.m. UTC
Make it easier for other platforms like odp-dpdk to reuse arch specific
files in EXTRA_DIST for "free".

Reported-by: Fathi Boudra <fathi.boudra@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 platform/Makefile.inc              | 17 +++++++++++++++++
 platform/linux-generic/Makefile.am | 17 -----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

-- 
2.1.4

Comments

Mike Holmes July 21, 2016, 1:12 p.m. UTC | #1
On 21 July 2016 at 05:42, Anders Roxell <anders.roxell@linaro.org> wrote:

> Make it easier for other platforms like odp-dpdk to reuse arch specific

> files in EXTRA_DIST for "free".

>

> Reported-by: Fathi Boudra <fathi.boudra@linaro.org>

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>


Maxim can you delete the duplicate signoff above form Anders ?

Reviewd-by: Mike Holmes <mike.holmes@linaro.org>


> ---

>  platform/Makefile.inc              | 17 +++++++++++++++++

>  platform/linux-generic/Makefile.am | 17 -----------------

>  2 files changed, 17 insertions(+), 17 deletions(-)

>

> diff --git a/platform/Makefile.inc b/platform/Makefile.inc

> index 053bd12..370383b 100644

> --- a/platform/Makefile.inc

> +++ b/platform/Makefile.inc

> @@ -60,3 +60,20 @@ odpapispecinclude_HEADERS = \

>                   $(top_srcdir)/include/odp/api/spec/timer.h \

>                   $(top_srcdir)/include/odp/api/spec/traffic_mngr.h \

>                   $(top_srcdir)/include/odp/api/spec/version.h

> +

> +EXTRA_DIST = \

> +            arch/default/odp/api/cpu_arch.h \

> +            arch/default/odp_cpu_arch.c \

> +            arch/default/odp_sysinfo_parse.c \

> +            arch/mips64/odp/api/cpu_arch.h \

> +            arch/mips64/odp_cpu_arch.c \

> +            arch/mips64/odp_sysinfo_parse.c \

> +            arch/powerpc/odp/api/cpu_arch.h \

> +            arch/powerpc/odp_cpu_arch.c \

> +            arch/powerpc/odp_sysinfo_parse.c \

> +            arch/x86/odp/api/cpu_arch.h \

> +            arch/x86/odp_cpu_arch.c \

> +            arch/x86/odp_sysinfo_parse.c \

> +            arch/arm/odp/api/cpu_arch.h \

> +            arch/arm/odp_cpu_arch.c \

> +            arch/arm/odp_sysinfo_parse.c

> diff --git a/platform/linux-generic/Makefile.am

> b/platform/linux-generic/Makefile.am

> index c8fd8cb..0cfd0fe 100644

> --- a/platform/linux-generic/Makefile.am

> +++ b/platform/linux-generic/Makefile.am

> @@ -186,23 +186,6 @@ __LIB__libodp_linux_la_SOURCES = \

>                            arch/@ARCH_DIR@/odp_cpu_arch.c \

>                            arch/@ARCH_DIR@/odp_sysinfo_parse.c

>

> -EXTRA_DIST = \

> -            arch/default/odp/api/cpu_arch.h \

> -            arch/default/odp_cpu_arch.c \

> -            arch/default/odp_sysinfo_parse.c \

> -            arch/mips64/odp/api/cpu_arch.h \

> -            arch/mips64/odp_cpu_arch.c \

> -            arch/mips64/odp_sysinfo_parse.c \

> -            arch/powerpc/odp/api/cpu_arch.h \

> -            arch/powerpc/odp_cpu_arch.c \

> -            arch/powerpc/odp_sysinfo_parse.c \

> -            arch/x86/odp/api/cpu_arch.h \

> -            arch/x86/odp_cpu_arch.c \

> -            arch/x86/odp_sysinfo_parse.c \

> -            arch/arm/odp/api/cpu_arch.h \

> -            arch/arm/odp_cpu_arch.c \

> -            arch/arm/odp_sysinfo_parse.c

> -

>  if HAVE_PCAP

>  __LIB__libodp_linux_la_SOURCES += pktio/pcap.c

>  endif

> --

> 2.1.4

>

>



-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Anders Roxell July 21, 2016, 1:15 p.m. UTC | #2
On 21 July 2016 at 15:12, Mike Holmes <mike.holmes@linaro.org> wrote:
>

>

> On 21 July 2016 at 05:42, Anders Roxell <anders.roxell@linaro.org> wrote:

>>

>> Make it easier for other platforms like odp-dpdk to reuse arch specific

>> files in EXTRA_DIST for "free".

>>

>> Reported-by: Fathi Boudra <fathi.boudra@linaro.org>

>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>>

>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>

>

> Maxim can you delete the duplicate signoff above form Anders ?

>

> Reviewd-by: Mike Holmes <mike.holmes@linaro.org>


Maxim, you should be able to take my v2 I cleaned up the duplicated sob.

Cheers,
Anders

>

>>

>> ---

>>  platform/Makefile.inc              | 17 +++++++++++++++++

>>  platform/linux-generic/Makefile.am | 17 -----------------

>>  2 files changed, 17 insertions(+), 17 deletions(-)

>>

>> diff --git a/platform/Makefile.inc b/platform/Makefile.inc

>> index 053bd12..370383b 100644

>> --- a/platform/Makefile.inc

>> +++ b/platform/Makefile.inc

>> @@ -60,3 +60,20 @@ odpapispecinclude_HEADERS = \

>>                   $(top_srcdir)/include/odp/api/spec/timer.h \

>>                   $(top_srcdir)/include/odp/api/spec/traffic_mngr.h \

>>                   $(top_srcdir)/include/odp/api/spec/version.h

>> +

>> +EXTRA_DIST = \

>> +            arch/default/odp/api/cpu_arch.h \

>> +            arch/default/odp_cpu_arch.c \

>> +            arch/default/odp_sysinfo_parse.c \

>> +            arch/mips64/odp/api/cpu_arch.h \

>> +            arch/mips64/odp_cpu_arch.c \

>> +            arch/mips64/odp_sysinfo_parse.c \

>> +            arch/powerpc/odp/api/cpu_arch.h \

>> +            arch/powerpc/odp_cpu_arch.c \

>> +            arch/powerpc/odp_sysinfo_parse.c \

>> +            arch/x86/odp/api/cpu_arch.h \

>> +            arch/x86/odp_cpu_arch.c \

>> +            arch/x86/odp_sysinfo_parse.c \

>> +            arch/arm/odp/api/cpu_arch.h \

>> +            arch/arm/odp_cpu_arch.c \

>> +            arch/arm/odp_sysinfo_parse.c

>> diff --git a/platform/linux-generic/Makefile.am

>> b/platform/linux-generic/Makefile.am

>> index c8fd8cb..0cfd0fe 100644

>> --- a/platform/linux-generic/Makefile.am

>> +++ b/platform/linux-generic/Makefile.am

>> @@ -186,23 +186,6 @@ __LIB__libodp_linux_la_SOURCES = \

>>                            arch/@ARCH_DIR@/odp_cpu_arch.c \

>>                            arch/@ARCH_DIR@/odp_sysinfo_parse.c

>>

>> -EXTRA_DIST = \

>> -            arch/default/odp/api/cpu_arch.h \

>> -            arch/default/odp_cpu_arch.c \

>> -            arch/default/odp_sysinfo_parse.c \

>> -            arch/mips64/odp/api/cpu_arch.h \

>> -            arch/mips64/odp_cpu_arch.c \

>> -            arch/mips64/odp_sysinfo_parse.c \

>> -            arch/powerpc/odp/api/cpu_arch.h \

>> -            arch/powerpc/odp_cpu_arch.c \

>> -            arch/powerpc/odp_sysinfo_parse.c \

>> -            arch/x86/odp/api/cpu_arch.h \

>> -            arch/x86/odp_cpu_arch.c \

>> -            arch/x86/odp_sysinfo_parse.c \

>> -            arch/arm/odp/api/cpu_arch.h \

>> -            arch/arm/odp_cpu_arch.c \

>> -            arch/arm/odp_sysinfo_parse.c

>> -

>>  if HAVE_PCAP

>>  __LIB__libodp_linux_la_SOURCES += pktio/pcap.c

>>  endif

>> --

>> 2.1.4

>>

>

>

>

> --

> Mike Holmes

> Technical Manager - Linaro Networking Group

> Linaro.org │ Open source software for ARM SoCs

> "Work should be fun and collaborative, the rest follows"

>

>
diff mbox

Patch

diff --git a/platform/Makefile.inc b/platform/Makefile.inc
index 053bd12..370383b 100644
--- a/platform/Makefile.inc
+++ b/platform/Makefile.inc
@@ -60,3 +60,20 @@  odpapispecinclude_HEADERS = \
 		  $(top_srcdir)/include/odp/api/spec/timer.h \
 		  $(top_srcdir)/include/odp/api/spec/traffic_mngr.h \
 		  $(top_srcdir)/include/odp/api/spec/version.h
+
+EXTRA_DIST = \
+	     arch/default/odp/api/cpu_arch.h \
+	     arch/default/odp_cpu_arch.c \
+	     arch/default/odp_sysinfo_parse.c \
+	     arch/mips64/odp/api/cpu_arch.h \
+	     arch/mips64/odp_cpu_arch.c \
+	     arch/mips64/odp_sysinfo_parse.c \
+	     arch/powerpc/odp/api/cpu_arch.h \
+	     arch/powerpc/odp_cpu_arch.c \
+	     arch/powerpc/odp_sysinfo_parse.c \
+	     arch/x86/odp/api/cpu_arch.h \
+	     arch/x86/odp_cpu_arch.c \
+	     arch/x86/odp_sysinfo_parse.c \
+	     arch/arm/odp/api/cpu_arch.h \
+	     arch/arm/odp_cpu_arch.c \
+	     arch/arm/odp_sysinfo_parse.c
diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am
index c8fd8cb..0cfd0fe 100644
--- a/platform/linux-generic/Makefile.am
+++ b/platform/linux-generic/Makefile.am
@@ -186,23 +186,6 @@  __LIB__libodp_linux_la_SOURCES = \
 			   arch/@ARCH_DIR@/odp_cpu_arch.c \
 			   arch/@ARCH_DIR@/odp_sysinfo_parse.c
 
-EXTRA_DIST = \
-	     arch/default/odp/api/cpu_arch.h \
-	     arch/default/odp_cpu_arch.c \
-	     arch/default/odp_sysinfo_parse.c \
-	     arch/mips64/odp/api/cpu_arch.h \
-	     arch/mips64/odp_cpu_arch.c \
-	     arch/mips64/odp_sysinfo_parse.c \
-	     arch/powerpc/odp/api/cpu_arch.h \
-	     arch/powerpc/odp_cpu_arch.c \
-	     arch/powerpc/odp_sysinfo_parse.c \
-	     arch/x86/odp/api/cpu_arch.h \
-	     arch/x86/odp_cpu_arch.c \
-	     arch/x86/odp_sysinfo_parse.c \
-	     arch/arm/odp/api/cpu_arch.h \
-	     arch/arm/odp_cpu_arch.c \
-	     arch/arm/odp_sysinfo_parse.c
-
 if HAVE_PCAP
 __LIB__libodp_linux_la_SOURCES += pktio/pcap.c
 endif