diff mbox

[2/2] ARM: DRA7: select PCI_DOMAINS config

Message ID 1469102276-14777-3-git-send-email-kishon@ti.com
State New
Headers show

Commit Message

Kishon Vijay Abraham I July 21, 2016, 11:57 a.m. UTC
PCI_DOMAINS is required for DRA7x SoCs since there are 2 PCIe
controllers and without PCI_DOMAINS config, only one PCIe
controller gets registered.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 file changed, 1 insertion(+)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Arnd Bergmann July 21, 2016, 12:04 p.m. UTC | #1
On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig

> index 1a648e9..8e6e2c0 100644

> --- a/arch/arm/mach-omap2/Kconfig

> +++ b/arch/arm/mach-omap2/Kconfig

> @@ -86,6 +86,7 @@ config SOC_DRA7XX

>         select OMAP_INTERCONNECT_BARRIER

>         select PM_OPP if PM

>         select ZONE_DMA if ARM_LPAE

> +       select PCI_DOMAINS if PCI

>  

>  config ARCH_OMAP2PLUS

>         bool

> 


Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren July 22, 2016, 7:16 a.m. UTC | #2
* Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:

> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig

> > index 1a648e9..8e6e2c0 100644

> > --- a/arch/arm/mach-omap2/Kconfig

> > +++ b/arch/arm/mach-omap2/Kconfig

> > @@ -86,6 +86,7 @@ config SOC_DRA7XX

> >         select OMAP_INTERCONNECT_BARRIER

> >         select PM_OPP if PM

> >         select ZONE_DMA if ARM_LPAE

> > +       select PCI_DOMAINS if PCI

> >  

> >  config ARCH_OMAP2PLUS

> >         bool

> > 

> 

> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?


Makes sense to me if many SoCs need this.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kishon Vijay Abraham I July 22, 2016, 8:26 a.m. UTC | #3
Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:

>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:

>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig

>>> index 1a648e9..8e6e2c0 100644

>>> --- a/arch/arm/mach-omap2/Kconfig

>>> +++ b/arch/arm/mach-omap2/Kconfig

>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX

>>>         select OMAP_INTERCONNECT_BARRIER

>>>         select PM_OPP if PM

>>>         select ZONE_DMA if ARM_LPAE

>>> +       select PCI_DOMAINS if PCI

>>>  

>>>  config ARCH_OMAP2PLUS

>>>         bool

>>>

>>

>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?

> 

> Makes sense to me if many SoCs need this.


since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.


Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.htmldiff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

diff mbox

Patch

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 1a648e9..8e6e2c0 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -86,6 +86,7 @@  config SOC_DRA7XX
 	select OMAP_INTERCONNECT_BARRIER
 	select PM_OPP if PM
 	select ZONE_DMA if ARM_LPAE
+	select PCI_DOMAINS if PCI
 
 config ARCH_OMAP2PLUS
 	bool