diff mbox series

[v3,2/6] dt-bindings: display/msm: Add reg bus and rotator interconnects

Message ID 20230928113535.1217613-3-dmitry.baryshkov@linaro.org
State New
Headers show
Series MDSS reg bus interconnect | expand

Commit Message

Dmitry Baryshkov Sept. 28, 2023, 11:35 a.m. UTC
From: Konrad Dybcio <konrad.dybcio@linaro.org>

Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
other connection paths:
- a path that connects rotator block to the DDR.
- a path that needs to be handled to ensure MDSS register access
  functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
  interconnect.

Describe these paths bindings to allow using them in device trees and in
the driver

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Neil Armstrong Nov. 6, 2023, 3:45 p.m. UTC | #1
Hi,

On 28/09/2023 13:35, Dmitry Baryshkov wrote:
> From: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
> other connection paths:
> - a path that connects rotator block to the DDR.
> - a path that needs to be handled to ensure MDSS register access
>    functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
>    interconnect.
> 
> Describe these paths bindings to allow using them in device trees and in
> the driver
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> index f69196e4cc76..6b4ce08a60dc 100644
> --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> @@ -66,12 +66,14 @@ properties:
>       items:
>         - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
>         - description: Interconnect path from mdp1 port to the data bus
> +      - description: Interconnect path from CPU to the reg bus
>   
>     interconnect-names:
>       minItems: 1
>       items:
>         - const: mdp0-mem
>         - const: mdp1-mem
> +      - const: cpu-cfg
>   
>     resets:
>       items:

This is not enough, on sm8450 this still appears with patch applied:
arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem@ae00000: interconnects: [[182, 14, 0, 30, 3, 0], [182, 14, 0, 30, 3, 0], [53, 2, 3, 183, 14, 3]] is too long
         from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#
arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long
         from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#

This is also needed:
==========><================================
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
index 001b26e65301..e94e8630cc85 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
@@ -30,10 +30,10 @@ properties:
      maxItems: 1

    interconnects:
-    maxItems: 2
+    maxItems: 3

    interconnect-names:
-    maxItems: 2
+    maxItems: 3

  patternProperties:
    "^display-controller@[0-9a-f]+$":
==============================================

Thanks,
Neil
Konrad Dybcio Nov. 7, 2023, 9:32 p.m. UTC | #2
On 11/6/23 16:45, Neil Armstrong wrote:
> Hi,
> 
> On 28/09/2023 13:35, Dmitry Baryshkov wrote:
>> From: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
>> other connection paths:
>> - a path that connects rotator block to the DDR.
>> - a path that needs to be handled to ensure MDSS register access
>>    functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
>>    interconnect.
>>
>> Describe these paths bindings to allow using them in device trees and in
>> the driver
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> index f69196e4cc76..6b4ce08a60dc 100644
>> --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> @@ -66,12 +66,14 @@ properties:
>>       items:
>>         - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
>>         - description: Interconnect path from mdp1 port to the data bus
>> +      - description: Interconnect path from CPU to the reg bus
>>     interconnect-names:
>>       minItems: 1
>>       items:
>>         - const: mdp0-mem
>>         - const: mdp1-mem
>> +      - const: cpu-cfg
>>     resets:
>>       items:
> 
> This is not enough, on sm8450 this still appears with patch applied:
> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem@ae00000: interconnects: [[182, 14, 0, 30, 3, 0], [182, 14, 0, 30, 3, 0], [53, 2, 3, 183, 14, 3]] is too long
>          from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#
> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long
>          from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#
I assume this is with the path actually added in the dt, and
not just with this patch applied?

I guess increasing the numbers from the getgo would probably
be good idea too :)

Konrad
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
index f69196e4cc76..6b4ce08a60dc 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
@@ -66,12 +66,14 @@  properties:
     items:
       - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
       - description: Interconnect path from mdp1 port to the data bus
+      - description: Interconnect path from CPU to the reg bus
 
   interconnect-names:
     minItems: 1
     items:
       - const: mdp0-mem
       - const: mdp1-mem
+      - const: cpu-cfg
 
   resets:
     items: