| Message ID | 20230929101649.20206-1-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | 8894b432548851f705f72ff135d3dcbd442a18d1 |
| Headers | show |
| Series | power: supply: qcom_battmgr: fix enable request endianness | expand |
On Fri, Sep 29, 2023 at 12:16:49PM +0200, Johan Hovold wrote: > Add the missing endianness conversion when sending the enable request so > that the driver will work also on a hypothetical big-endian machine. > > This issue was reported by sparse. > > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Cc: stable@vger.kernel.org # 6.3 > Cc: Bjorn Andersson <andersson@kernel.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
On Fri, 29 Sep 2023 12:16:49 +0200, Johan Hovold wrote: > Add the missing endianness conversion when sending the enable request so > that the driver will work also on a hypothetical big-endian machine. > > This issue was reported by sparse. > > Applied, thanks! [1/1] power: supply: qcom_battmgr: fix enable request endianness commit: 8894b432548851f705f72ff135d3dcbd442a18d1 Best regards,
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index de77df97b3a4..6ec71276bb70 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -1282,9 +1282,9 @@ static void qcom_battmgr_enable_worker(struct work_struct *work) { struct qcom_battmgr *battmgr = container_of(work, struct qcom_battmgr, enable_work); struct qcom_battmgr_enable_request req = { - .hdr.owner = PMIC_GLINK_OWNER_BATTMGR, - .hdr.type = PMIC_GLINK_NOTIFY, - .hdr.opcode = BATTMGR_REQUEST_NOTIFICATION, + .hdr.owner = cpu_to_le32(PMIC_GLINK_OWNER_BATTMGR), + .hdr.type = cpu_to_le32(PMIC_GLINK_NOTIFY), + .hdr.opcode = cpu_to_le32(BATTMGR_REQUEST_NOTIFICATION), }; int ret;
Add the missing endianness conversion when sending the enable request so that the driver will work also on a hypothetical big-endian machine. This issue was reported by sparse. Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") Cc: stable@vger.kernel.org # 6.3 Cc: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/power/supply/qcom_battmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)