gstreamer1.0-plugins-bad: add missing wayland-native dependency

Message ID 1469637177-2657-1-git-send-email-ross.burton@intel.com
State Accepted
Commit 951417b7a3a6388ddb0e9d89802e50d60f02e146
Headers show

Commit Message

Ross Burton July 27, 2016, 4:32 p.m.
The wayland support requires wayland-scanner, so add a dependency on
wayland-native.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.8.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton July 27, 2016, 7:51 p.m. | #1
On 27 July 2016 at 18:07, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Jul 27, 2016 at 05:32:57PM +0100, Ross Burton wrote:

> > The wayland support requires wayland-scanner, so add a dependency on

> > wayland-native.

>

> Why is this needed when wayland already depends on wayland-native?

>


Because builds from sstate won't pull in all the build dependencies
transitively, just enough to do the required tasks. The requirements are
the wayland runtime libraries (wayland) and the native tooling
(wayland-native).

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj July 28, 2016, 1:40 a.m. | #2
> On Jul 27, 2016, at 12:51 PM, Burton, Ross <ross.burton@intel.com> wrote:

> 

> 

> On 27 July 2016 at 18:07, Martin Jansa <martin.jansa@gmail.com <mailto:martin.jansa@gmail.com>> wrote:

> On Wed, Jul 27, 2016 at 05:32:57PM +0100, Ross Burton wrote:

> > The wayland support requires wayland-scanner, so add a dependency on

> > wayland-native.

> 

> Why is this needed when wayland already depends on wayland-native?

> 

> Because builds from sstate won't pull in all the build dependencies transitively, just enough to do the required tasks. The requirements are the wayland runtime libraries (wayland) and the native tooling (waylaid-native).


Is it so that populate_sysroot tasks wont do the above two jobs ? if yes then why
If you are saying that behavior is different with or without sstate reuse if  I do
bitbake gstreamer1.0-plugins-bad, then I think there is a problem.  The entries changed here will
get added to DEPENDS in the end. So Martin has a point.

> 

> Ross

> 

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
index 9e2b94e..d8c8179 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
@@ -58,7 +58,7 @@  PACKAGECONFIG[srtp]            = "--enable-srtp,--disable-srtp,libsrtp"
 PACKAGECONFIG[uvch264]         = "--enable-uvch264,--disable-uvch264,libusb1 libgudev"
 PACKAGECONFIG[voaacenc]        = "--enable-voaacenc,--disable-voaacenc,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "--enable-voamrwbenc,--disable-voamrwbenc,vo-amrwbenc"
-PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland virtual/egl"
+PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland-native wayland virtual/egl"
 PACKAGECONFIG[webp]            = "--enable-webp,--disable-webp,libwebp"
 
 # these plugins have not been ported to 1.0 (yet):