| Message ID | 20231026004730.28339-1-thiago.bauermann@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself | expand |
On 10/26/23 01:47, Thiago Jung Bauermann wrote: > GCC doesn't complain, but it's still wrong. > --- > gdb/nat/aarch64-scalable-linux-ptrace.h | 1 - > 1 file changed, 1 deletion(-) > > I just spotted the problem, and pushed this patch to fix it under the > obvious rule. > > diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h b/gdb/nat/aarch64-scalable-linux-ptrace.h > index 69c9982b0096..8ff2a96ceb16 100644 > --- a/gdb/nat/aarch64-scalable-linux-ptrace.h > +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h > @@ -32,7 +32,6 @@ > #include <sys/ptrace.h> > #include <asm/ptrace.h> > #include <stdarg.h> > -#include "aarch64-scalable-linux-ptrace.h" > #include "aarch64-scalable-linux-sigcontext.h" > > /* Indicates whether a SVE ptrace header is followed by SVE registers or a > > base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14.
Hello Luis, Luis Machado <luis.machado@arm.com> writes: > On 10/26/23 01:47, Thiago Jung Bauermann wrote: >> GCC doesn't complain, but it's still wrong. >> --- >> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 - >> 1 file changed, 1 deletion(-) >> >> I just spotted the problem, and pushed this patch to fix it under the >> obvious rule. >> >> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h >> b/gdb/nat/aarch64-scalable-linux-ptrace.h >> index 69c9982b0096..8ff2a96ceb16 100644 >> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h >> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h >> @@ -32,7 +32,6 @@ >> #include <sys/ptrace.h> >> #include <asm/ptrace.h> >> #include <stdarg.h> >> -#include "aarch64-scalable-linux-ptrace.h" >> #include "aarch64-scalable-linux-sigcontext.h" >> >> /* Indicates whether a SVE ptrace header is followed by SVE registers or a >> >> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e > > Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14. Good idea. I just pushed to gdb-14-branch.
On 10/26/23 14:23, Thiago Jung Bauermann wrote: > > Hello Luis, > > Luis Machado <luis.machado@arm.com> writes: > >> On 10/26/23 01:47, Thiago Jung Bauermann wrote: >>> GCC doesn't complain, but it's still wrong. >>> --- >>> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> I just spotted the problem, and pushed this patch to fix it under the >>> obvious rule. >>> >>> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h >>> b/gdb/nat/aarch64-scalable-linux-ptrace.h >>> index 69c9982b0096..8ff2a96ceb16 100644 >>> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h >>> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h >>> @@ -32,7 +32,6 @@ >>> #include <sys/ptrace.h> >>> #include <asm/ptrace.h> >>> #include <stdarg.h> >>> -#include "aarch64-scalable-linux-ptrace.h" >>> #include "aarch64-scalable-linux-sigcontext.h" >>> >>> /* Indicates whether a SVE ptrace header is followed by SVE registers or a >>> >>> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e >> >> Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14. > > Good idea. I just pushed to gdb-14-branch. > Great. Thanks for chasing this.
diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h b/gdb/nat/aarch64-scalable-linux-ptrace.h index 69c9982b0096..8ff2a96ceb16 100644 --- a/gdb/nat/aarch64-scalable-linux-ptrace.h +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h @@ -32,7 +32,6 @@ #include <sys/ptrace.h> #include <asm/ptrace.h> #include <stdarg.h> -#include "aarch64-scalable-linux-ptrace.h" #include "aarch64-scalable-linux-sigcontext.h" /* Indicates whether a SVE ptrace header is followed by SVE registers or a