| Message ID | 20231025190619.881090-2-robh@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,v2] leds: syscon: Support 'reg' in addition to 'offset' for register address | expand |
On Wed, Oct 25, 2023 at 9:09 PM Rob Herring <robh@kernel.org> wrote: > The register-bit-led binding now also supports 'reg' in addition to > 'offset' for the register address. Add support to the driver to get the > address from 'reg'. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: linux-leds@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c index 360a376fa738..d633ad519d0c 100644 --- a/drivers/leds/leds-syscon.c +++ b/drivers/leds/leds-syscon.c @@ -81,7 +81,8 @@ static int syscon_led_probe(struct platform_device *pdev) sled->map = map; - if (of_property_read_u32(np, "offset", &sled->offset)) + if (of_property_read_u32(np, "reg", &sled->offset) && + of_property_read_u32(np, "offset", &sled->offset)) return -EINVAL; if (of_property_read_u32(np, "mask", &sled->mask)) return -EINVAL;
The register-bit-led binding now also supports 'reg' in addition to 'offset' for the register address. Add support to the driver to get the address from 'reg'. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: linux-leds@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- The binding change landed, but v2[1] was never applied. [1] https://lore.kernel.org/all/20210913192816.1225025-3-robh@kernel.org/ drivers/leds/leds-syscon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)