From patchwork Tue Aug 16 19:41:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 74039 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2165289qga; Tue, 16 Aug 2016 12:41:48 -0700 (PDT) X-Received: by 10.66.43.7 with SMTP id s7mr68016328pal.27.1471376507737; Tue, 16 Aug 2016 12:41:47 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n89si33484262pfa.261.2016.08.16.12.41.47 for ; Tue, 16 Aug 2016 12:41:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbcHPTlq (ORCPT ); Tue, 16 Aug 2016 15:41:46 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36829 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcHPTlq (ORCPT ); Tue, 16 Aug 2016 15:41:46 -0400 Received: by mail-wm0-f50.google.com with SMTP id q128so162799308wma.1 for ; Tue, 16 Aug 2016 12:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=aQ54467ZhqgrzcPR116fNxhMEkZ6d4LlJYdsgmTN/go=; b=TV+Jhx+WO1Ss/FjKhh26Hh04zgQp19pJNaVHn27ewsvFOA6rQT5SSepucVEV/8MlZc 0zF36UVW/0NzhYk3osgrBfNBG4HFViQJbs5If1fBtg7lLzTppv+ONvRFqZ1TJICM5jbV d0z8UX5LtNwCKPGYllYLKINmJVXkCxT7XZCIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aQ54467ZhqgrzcPR116fNxhMEkZ6d4LlJYdsgmTN/go=; b=Joln26192mo5FBYzpv2ozDKkkqUU2wIg47m6Me57QoueDBzfaP/jmIiLiBuAxGgZbl B+XQVWQaYBimIxZi9Xb3U+1DgixGYjnnc+VlNcfdghrK4Oqm1R4jJkmuWEcaLypT2PJC ZftteMqxA1dZFt4RjPIsFVwGPxGytlt6RwGJ6JPXlobWGjxWXxvxELN5JWjZInLcZood wXR/PBa4kQA1nJZhvbP5qHdwR60Gsd1Epdx1L/F33exmgX9giRAkYcqQP1b/rhZoJjOU GDibaqEPnft9jBXvyotMcoCqUenTlUPtmBJGK+AIklYdvWy2Flyt8sRFWG86T9v+YtBH lU6g== X-Gm-Message-State: AEkoouvomWv+wfSPn4hONHiDu0f7iViX6IuGEEe85hF90qosUeS+MPT1xF8yvqnoq22v0Sh9 X-Received: by 10.25.156.77 with SMTP id f74mr4670662lfe.51.1471376504283; Tue, 16 Aug 2016 12:41:44 -0700 (PDT) Received: from localhost.localdomain.localdomain (c-357171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.53]) by smtp.gmail.com with ESMTPSA id f4sm1024776lji.41.2016.08.16.12.41.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 12:41:43 -0700 (PDT) From: Linus Walleij To: Jacek Anaszewski , Richard Purdie , devicetree@vger.kernel.org Cc: linux-leds@vger.kernel.org, Linus Walleij Subject: [PATCH RESEND] leds: centralize definition of "default-state" property Date: Tue, 16 Aug 2016 21:41:36 +0200 Message-Id: <1471376496-8706-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Four different drivers define the "default-state" property. Move this into the common.txt common LEDs properties. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij --- Resending trying to get attention from the devicetree maintainers. --- Documentation/devicetree/bindings/leds/common.txt | 7 +++++++ Documentation/devicetree/bindings/leds/leds-bcm6328.txt | 2 +- Documentation/devicetree/bindings/leds/leds-bcm6358.txt | 2 +- Documentation/devicetree/bindings/leds/leds-gpio.txt | 9 ++------- Documentation/devicetree/bindings/leds/register-bit-led.txt | 9 ++------- 5 files changed, 13 insertions(+), 16 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt index 93ef6e6e43b5..696be5792625 100644 --- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt @@ -19,6 +19,13 @@ Optional properties for child nodes: a device, i.e. no other LED class device can be assigned the same label. +- default-state : The initial state of the LED. Valid values are "on", "off", + and "keep". If the LED is already on or off and the default-state property is + set the to same value, then no glitch should be produced where the LED + momentarily turns off (or on). The "keep" setting will keep the LED at + whatever its current state is, without producing a glitch. The default is + off if this property is not present. + - linux,default-trigger : This parameter, if present, is a string defining the trigger assigned to the LED. Current triggers are: "backlight" - LED will act as a back-light, controlled by the framebuffer diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6328.txt b/Documentation/devicetree/bindings/leds/leds-bcm6328.txt index 3f48c1eaf085..ccebce597f37 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm6328.txt +++ b/Documentation/devicetree/bindings/leds/leds-bcm6328.txt @@ -49,7 +49,7 @@ LED sub-node optional properties: - active-low : Boolean, makes LED active low. Default : false - default-state : see - Documentation/devicetree/bindings/leds/leds-gpio.txt + Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : see Documentation/devicetree/bindings/leds/common.txt diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt index b22a55bcc65d..da5708e7b43b 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt +++ b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt @@ -28,7 +28,7 @@ LED sub-node optional properties: - active-low : Boolean, makes LED active low. Default : false - default-state : see - Documentation/devicetree/bindings/leds/leds-gpio.txt + Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : see Documentation/devicetree/bindings/leds/common.txt diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt index 5b1b43a64265..76535ca37120 100644 --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt @@ -14,13 +14,8 @@ LED sub-node properties: see Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : (optional) see Documentation/devicetree/bindings/leds/common.txt -- default-state: (optional) The initial state of the LED. Valid - values are "on", "off", and "keep". If the LED is already on or off - and the default-state property is set the to same value, then no - glitch should be produced where the LED momentarily turns off (or - on). The "keep" setting will keep the LED at whatever its current - state is, without producing a glitch. The default is off if this - property is not present. +- default-state: (optional) The initial state of the LED. + see Documentation/devicetree/bindings/leds/common.txt - retain-state-suspended: (optional) The suspend state can be retained.Such as charge-led gpio. - panic-indicator : (optional) diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.txt b/Documentation/devicetree/bindings/leds/register-bit-led.txt index 379cefdc0bda..59b56365f648 100644 --- a/Documentation/devicetree/bindings/leds/register-bit-led.txt +++ b/Documentation/devicetree/bindings/leds/register-bit-led.txt @@ -23,13 +23,8 @@ Optional properties: see Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : (optional) see Documentation/devicetree/bindings/leds/common.txt -- default-state: (optional) The initial state of the LED. Valid - values are "on", "off", and "keep". If the LED is already on or off - and the default-state property is set the to same value, then no - glitch should be produced where the LED momentarily turns off (or - on). The "keep" setting will keep the LED at whatever its current - state is, without producing a glitch. The default is off if this - property is not present. +- default-state: (optional) The initial state of the LED + see Documentation/devicetree/bindings/leds/common.txt Example: