| Message ID | 20231111164229.63803-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | af6f6778d34cb40e60368e288767f674cc0c5f60 |
| Headers | show |
| Series | [1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs | expand |
On 11.11.2023 17:42, Krzysztof Kozlowski wrote: > Linux handles both versions, but bindings expect GPIO properties to > have 'gpios' suffix instead of 'gpio': > > sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- What about the 'enable-gpio' right below it? Konrad
On 13/11/2023 13:00, Konrad Dybcio wrote: > On 11.11.2023 17:42, Krzysztof Kozlowski wrote: >> Linux handles both versions, but bindings expect GPIO properties to >> have 'gpios' suffix instead of 'gpio': >> >> sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected) >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > What about the 'enable-gpio' right below it? It needs to be documented first. enable-gpio/s seems to be missing from the bindings and I did not have enough of time to investigate whether this is correct in the first place. That's why I thought about fixing only already accepted perst-gpios. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index e39de6596a1e..9bcdc485c73a 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1878,7 +1878,7 @@ pcie0: pci@1c00000 { phys = <&pcie0_phy>; phy-names = "pciephy"; - perst-gpio = <&tlmm 35 GPIO_ACTIVE_HIGH>; + perst-gpios = <&tlmm 35 GPIO_ACTIVE_HIGH>; enable-gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; @@ -1972,7 +1972,7 @@ pcie1: pci@1c08000 { phys = <&pcie1_phy>; phy-names = "pciephy"; - perst-gpio = <&tlmm 102 GPIO_ACTIVE_HIGH>; + perst-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>; enable-gpio = <&tlmm 104 GPIO_ACTIVE_HIGH>; pinctrl-names = "default";
Linux handles both versions, but bindings expect GPIO properties to have 'gpios' suffix instead of 'gpio': sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)