diff mbox series

[03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

Message ID 20231113112344.719-4-hkallweit1@gmail.com
State Superseded
Headers show
Series [01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support | expand

Commit Message

Heiner Kallweit Nov. 13, 2023, 11:23 a.m. UTC
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Harry Wentland Nov. 13, 2023, 5:50 p.m. UTC | #1
Please just use "drm/amd/display:" as tag in the commit subject.

With that fixed, this is
Acked-by: Harry Wentland <harry.wentland@amd.com>

Harry

On 2023-11-13 06:23, Heiner Kallweit wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
> 
> Preferably this series should be applied via the i2c tree.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 6f99f6754..ae1edc6ab 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
>  	if (!i2c)
>  		return NULL;
>  	i2c->base.owner = THIS_MODULE;
> -	i2c->base.class = I2C_CLASS_DDC;
>  	i2c->base.dev.parent = &adev->pdev->dev;
>  	i2c->base.algo = &amdgpu_dm_i2c_algo;
>  	snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
>
Heiner Kallweit Nov. 13, 2023, 6:32 p.m. UTC | #2
On 13.11.2023 18:50, Harry Wentland wrote:
> Please just use "drm/amd/display:" as tag in the commit subject.
> 
Thanks, noted. Tags have been automatically created by Coccinelle's splitpatch.

> With that fixed, this is
> Acked-by: Harry Wentland <harry.wentland@amd.com>
> 
> Harry
> 
> On 2023-11-13 06:23, Heiner Kallweit wrote:
>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>> Class-based device auto-detection is a legacy mechanism and shouldn't
>> be used in new code. So we can remove this class completely now.
>>
>> Preferably this series should be applied via the i2c tree.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>> ---
>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 6f99f6754..ae1edc6ab 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
>>  	if (!i2c)
>>  		return NULL;
>>  	i2c->base.owner = THIS_MODULE;
>> -	i2c->base.class = I2C_CLASS_DDC;
>>  	i2c->base.dev.parent = &adev->pdev->dev;
>>  	i2c->base.algo = &amdgpu_dm_i2c_algo;
>>  	snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
>>
>
Alex Deucher Nov. 16, 2023, 7:18 p.m. UTC | #3
On Mon, Nov 13, 2023 at 12:50 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> Please just use "drm/amd/display:" as tag in the commit subject.
>
> With that fixed, this is
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>

Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.

Alex

> Harry
>
> On 2023-11-13 06:23, Heiner Kallweit wrote:
> > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> > Class-based device auto-detection is a legacy mechanism and shouldn't
> > be used in new code. So we can remove this class completely now.
> >
> > Preferably this series should be applied via the i2c tree.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6f99f6754..ae1edc6ab 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
> >       if (!i2c)
> >               return NULL;
> >       i2c->base.owner = THIS_MODULE;
> > -     i2c->base.class = I2C_CLASS_DDC;
> >       i2c->base.dev.parent = &adev->pdev->dev;
> >       i2c->base.algo = &amdgpu_dm_i2c_algo;
> >       snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
> >
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6f99f6754..ae1edc6ab 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7529,7 +7529,6 @@  create_i2c(struct ddc_service *ddc_service,
 	if (!i2c)
 		return NULL;
 	i2c->base.owner = THIS_MODULE;
-	i2c->base.class = I2C_CLASS_DDC;
 	i2c->base.dev.parent = &adev->pdev->dev;
 	i2c->base.algo = &amdgpu_dm_i2c_algo;
 	snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);