diff mbox series

pinctrl: lochnagar: Don't build on MIPS

Message ID 20231115162853.1891940-1-ckeepax@opensource.cirrus.com
State Accepted
Commit 6588732445ff19f6183f0fa72ddedf67e5a5be32
Headers show
Series pinctrl: lochnagar: Don't build on MIPS | expand

Commit Message

Charles Keepax Nov. 15, 2023, 4:28 p.m. UTC
MIPS appears to define a RST symbol at a high level, which clashes
with some register naming in the driver. Since there is currently
no case for running this driver on MIPS devices simply cut off the
build of this driver on MIPS.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311071303.JJMAOjy4-lkp@intel.com/
Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 drivers/pinctrl/cirrus/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Linus Walleij Nov. 16, 2023, 1:40 p.m. UTC | #1
On Wed, Nov 15, 2023 at 5:28 PM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:

> MIPS appears to define a RST symbol at a high level, which clashes
> with some register naming in the driver. Since there is currently
> no case for running this driver on MIPS devices simply cut off the
> build of this driver on MIPS.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311071303.JJMAOjy4-lkp@intel.com/
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/cirrus/Kconfig b/drivers/pinctrl/cirrus/Kconfig
index d6318cb57aff2..c56220e05f57e 100644
--- a/drivers/pinctrl/cirrus/Kconfig
+++ b/drivers/pinctrl/cirrus/Kconfig
@@ -12,7 +12,8 @@  config PINCTRL_CS42L43
 
 config PINCTRL_LOCHNAGAR
 	tristate "Cirrus Logic Lochnagar pinctrl driver"
-	depends on MFD_LOCHNAGAR
+# Avoid clash caused by MIPS defining RST, which is used in the driver
+	depends on MFD_LOCHNAGAR && !MIPS
 	select GPIOLIB
 	select PINMUX
 	select PINCONF