[RFC,v2,11/11] spl: Kconfig: Add CONFIG_SPL_TEXT_BASE as Kconfig option

Message ID 20160822152131.15340-12-afd@ti.com
State New
Headers show

Commit Message

Andrew F. Davis Aug. 22, 2016, 3:21 p.m.
Add a new Kconfig CONFIG_SPL_TEXT_BASE. Set its default value to 0x0.

Signed-off-by: Andrew F. Davis <afd@ti.com>

---
 Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.9.3

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Masahiro Yamada Aug. 23, 2016, 5:45 a.m. | #1
2016-08-23 0:21 GMT+09:00 Andrew F. Davis <afd@ti.com>:
> Add a new Kconfig CONFIG_SPL_TEXT_BASE. Set its default value to 0x0.

>

> Signed-off-by: Andrew F. Davis <afd@ti.com>

> ---

>  Kconfig | 8 ++++++++

>  1 file changed, 8 insertions(+)

>

> diff --git a/Kconfig b/Kconfig

> index cb5af5b..2935c41 100644

> --- a/Kconfig

> +++ b/Kconfig

> @@ -319,6 +319,14 @@ config SYS_TEXT_BASE

>         help

>           TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture

>

> +config SPL_TEXT_BASE

> +       hex "SPL Text Base"

> +       depends on SPL

> +       default 0x0

> +       help

> +         When SPL is enabled the image is linked with this as the

> +         starting address in memeory for which the SPL will be loaded.

> +

>  config SPL_LOAD_FIT

>         bool "Enable SPL loading U-Boot as a FIT"

>         depends on FIT




For example, my SoC, configs/uniphier_ld20_defconfig,
needs to set CONFIG_SPL_TEXT_BASE to 0x100000
because its Boot ROM loads SPL onto 0x100000.

It is not user-configurable at all, so I do not see much sense for the prompt.
I am not quite sure for other SoCs, but I guess similar situation.

(If we support relocation for SPL, we can make SPL_TEXT_BASE
a configurable parameter, but we do not have it at this point of time.)


Is it better to hide the prompt unless EXPERT is defined?

config SPL_TEXT_BASE
       hex "SPL Text Base" if EXPERT





-- 
Best Regards
Masahiro Yamada
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Andrew F. Davis Aug. 23, 2016, 2:57 p.m. | #2
On 08/23/2016 12:45 AM, Masahiro Yamada wrote:
> 2016-08-23 0:21 GMT+09:00 Andrew F. Davis <afd@ti.com>:

>> Add a new Kconfig CONFIG_SPL_TEXT_BASE. Set its default value to 0x0.

>>

>> Signed-off-by: Andrew F. Davis <afd@ti.com>

>> ---

>>  Kconfig | 8 ++++++++

>>  1 file changed, 8 insertions(+)

>>

>> diff --git a/Kconfig b/Kconfig

>> index cb5af5b..2935c41 100644

>> --- a/Kconfig

>> +++ b/Kconfig

>> @@ -319,6 +319,14 @@ config SYS_TEXT_BASE

>>         help

>>           TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture

>>

>> +config SPL_TEXT_BASE

>> +       hex "SPL Text Base"

>> +       depends on SPL

>> +       default 0x0

>> +       help

>> +         When SPL is enabled the image is linked with this as the

>> +         starting address in memeory for which the SPL will be loaded.

>> +

>>  config SPL_LOAD_FIT

>>         bool "Enable SPL loading U-Boot as a FIT"

>>         depends on FIT

> 

> 

> 

> For example, my SoC, configs/uniphier_ld20_defconfig,

> needs to set CONFIG_SPL_TEXT_BASE to 0x100000

> because its Boot ROM loads SPL onto 0x100000.

> 

> It is not user-configurable at all, so I do not see much sense for the prompt.

> I am not quite sure for other SoCs, but I guess similar situation.

> 

> (If we support relocation for SPL, we can make SPL_TEXT_BASE

> a configurable parameter, but we do not have it at this point of time.)

> 

> 

> Is it better to hide the prompt unless EXPERT is defined?

> 

> config SPL_TEXT_BASE

>        hex "SPL Text Base" if EXPERT

> 

> 


I would be okay with this, I only really need this as a Kconfig option
so I can easily set it on a per defconfig basis
(am335x_evm_{boot_type}_defconfig), as you stated this isn't really for
users to change and so should be hidden by default.

Andrew
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/Kconfig b/Kconfig
index cb5af5b..2935c41 100644
--- a/Kconfig
+++ b/Kconfig
@@ -319,6 +319,14 @@  config SYS_TEXT_BASE
 	help
 	  TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture
 
+config SPL_TEXT_BASE
+	hex "SPL Text Base"
+	depends on SPL
+	default 0x0
+	help
+	  When SPL is enabled the image is linked with this as the
+	  starting address in memeory for which the SPL will be loaded.
+
 config SPL_LOAD_FIT
 	bool "Enable SPL loading U-Boot as a FIT"
 	depends on FIT