diff mbox series

scsi: ufs: core: Warn if the request tag is truncated

Message ID 20231115193359.2262044-1-bvanassche@acm.org
State New
Headers show
Series scsi: ufs: core: Warn if the request tag is truncated | expand

Commit Message

Bart Van Assche Nov. 15, 2023, 7:33 p.m. UTC
ufshcd_prepare_utp_scsi_cmd_upiu() only uses the lowest eight bits of
lrbp->task_tag. Issue a runtime warning if this results in truncation.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufshcd.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Martin K. Petersen Nov. 25, 2023, 12:18 a.m. UTC | #1
Bart,

> ufshcd_prepare_utp_scsi_cmd_upiu() only uses the lowest eight bits of
> lrbp->task_tag. Issue a runtime warning if this results in truncation.

Applied to 6.8/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 68d7da02944f..21fe4b125081 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2720,6 +2720,8 @@  void ufshcd_prepare_utp_scsi_cmd_upiu(struct ufshcd_lrb *lrbp, u8 upiu_flags)
 		.command_set_type = UPIU_COMMAND_SET_TYPE_SCSI,
 	};
 
+	WARN_ON_ONCE(ucd_req_ptr->header.task_tag != lrbp->task_tag);
+
 	ucd_req_ptr->sc.exp_data_transfer_len = cpu_to_be32(cmd->sdb.length);
 
 	cdb_len = min_t(unsigned short, cmd->cmd_len, UFS_CDB_SIZE);