diff mbox

[v2,2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

Message ID 1472094041-5357-2-git-send-email-guodong.xu@linaro.org
State Accepted
Commit 94914fc8046c907c2f175c28bea9c6aff0b118ac
Headers show

Commit Message

Guodong Xu Aug. 25, 2016, 3 a.m. UTC
Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220

Code and documentation to this property were confirmed by maintainers.
See:
[1] https://patchwork.kernel.org/patch/9276607/
[2] https://patchwork.kernel.org/patch/8487151/
[3] https://lkml.org/lkml/2016/8/12/91

cc: Jaehoon Chung <jh80.chung@samsung.com>
cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Guodong Xu <guodong.xu@linaro.org>

---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
 1 file changed, 3 insertions(+)

-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Comments

Jaehoon Chung Oct. 28, 2016, 7:33 a.m. UTC | #1
Hi,

On 10/28/2016 04:26 PM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 08:43:51AM +0200, Vincent Guittot wrote:

> 

> [...]

> 

>>> running with? Also do you have any details about the card in case its

>>> card specific?

>>

>> The sdcard is quite common: sandisk ultra 16GB

>> and my rootfs is on the sdcard

> 

> I'm using rootfs in emmc also have same failure.

> 

>>> Guodong: Is there any bootloader dependency on that change?

>>

>> FYI, I use firmwares available in AOSP

> 

> I tried latest firmware [1], still cannot boot up until revert the

> patch "arm64: dts: hi6220: add resets property into dwmmc nodes".


Could you share the log? Is there any log about failure?

Best Regards,
Jaehoon Chung

> 

> [1] http://builds.96boards.org/snapshots/hikey/linaro/uefi-openplatformpkg/latest/

> 

> Thanks,

> Leo Yan

> 

> 

> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index d0b887a..63608e9 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -771,6 +771,7 @@ 
 			interrupts = <0x0 0x48 0x4>;
 			clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
 			clock-names = "ciu", "biu";
+			resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
 			bus-width = <0x8>;
 			vmmc-supply = <&ldo19>;
 			pinctrl-names = "default";
@@ -790,6 +791,7 @@ 
 			#size-cells = <0x0>;
 			clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
 			clock-names = "ciu", "biu";
+			resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
 			vqmmc-supply = <&ldo7>;
 			vmmc-supply = <&ldo10>;
 			bus-width = <0x4>;
@@ -807,6 +809,7 @@ 
 			interrupts = <0x0 0x4a 0x4>;
 			clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
 			clock-names = "ciu", "biu";
+			resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
 			bus-width = <0x4>;
 			broken-cd;
 			pinctrl-names = "default", "idle";