| Message ID | 20231122090210.951185-1-suhui@nfschina.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [wireless-next,1/2] rtlwifi: rtl8821ae: phy: remove some useless code | expand |
> -----Original Message----- > From: Dan Carpenter <dan.carpenter@linaro.org> > Sent: Wednesday, November 22, 2023 9:02 PM > To: Su Hui <suhui@nfschina.com> > Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; nathan@kernel.org; ndesaulniers@google.com; > trix@redhat.com; lizetao1@huawei.com; linville@tuxdriver.com; Larry.Finger@lwfinger.net; > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; llvm@lists.linux.dev; > kernel-janitors@vger.kernel.org > Subject: Re: [PATCH wireless-next 2/2] rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior > > Perhaps, a better way to silence the warning is to just change > _rtl8821ae_phy_calculate_bit_shift() to not return 32 bits? Do we > really ever pass bitmask 0? No idea... > I think the bitmask should not 0, so just replace _rtl8821ae_phy_calculate_bit_shift() by __ffs(bitmask). To be safer, callers can check bitmask is not 0 before calling. Ping-Ke
> -----Original Message----- > From: Su Hui <suhui@nfschina.com> > Sent: Wednesday, November 22, 2023 5:02 PM > To: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; nathan@kernel.org; ndesaulniers@google.com; > trix@redhat.com > Cc: Su Hui <suhui@nfschina.com>; lizetao1@huawei.com; linux-wireless@vger.kernel.org; > linux-kernel@vger.kernel.org; llvm@lists.linux.dev; kernel-janitors@vger.kernel.org > Subject: [PATCH wireless-next 1/2] rtlwifi: rtl8821ae: phy: remove some useless code subject prefix should be "wifi: rtlwifi: ..." > > Clang static checker warning: > Value stored to 'v1' is never read [deadcode.DeadStores] > Value stored to 'channel' is never read [deadcode.DeadStores] > > Remove them to save some place. > > Signed-off-by: Su Hui <suhui@nfschina.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
On 2023/11/23 08:41, Ping-Ke Shih wrote: > >> -----Original Message----- >> From: Dan Carpenter <dan.carpenter@linaro.org> >> Sent: Wednesday, November 22, 2023 9:02 PM >> To: Su Hui <suhui@nfschina.com> >> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; nathan@kernel.org; ndesaulniers@google.com; >> trix@redhat.com; lizetao1@huawei.com; linville@tuxdriver.com; Larry.Finger@lwfinger.net; >> linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; llvm@lists.linux.dev; >> kernel-janitors@vger.kernel.org >> Subject: Re: [PATCH wireless-next 2/2] rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior >> >> Perhaps, a better way to silence the warning is to just change >> _rtl8821ae_phy_calculate_bit_shift() to not return 32 bits? Do we >> really ever pass bitmask 0? No idea... >> > I think the bitmask should not 0, so just replace _rtl8821ae_phy_calculate_bit_shift() > by __ffs(bitmask). To be safer, callers can check bitmask is not 0 before calling. Thanks for your great suggestion! I will send v2 soon. Su Hui
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index 5323ead30db0..6df270e29e66 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c @@ -2038,15 +2038,9 @@ static bool _rtl8821ae_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw, /*don't need the hw_body*/ if (!_rtl8821ae_check_condition(hw, v1)) { i += 2; /* skip the pair of expression*/ - v1 = array[i]; v2 = array[i+1]; - v3 = array[i+2]; - while (v2 != 0xDEAD) { + while (v2 != 0xDEAD) i += 3; - v1 = array[i]; - v2 = array[i+1]; - v3 = array[i+2]; - } } } } @@ -3543,7 +3537,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw) struct rtl_phy *rtlphy = &rtlpriv->phy; struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); u32 timeout = 1000, timecount = 0; - u8 channel = rtlphy->current_channel; if (rtlphy->sw_chnl_inprogress) return 0; @@ -3566,8 +3559,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw) rtl8821ae_phy_switch_wirelessband(hw, BAND_ON_2_4G); rtlphy->sw_chnl_inprogress = true; - if (channel == 0) - channel = 1; rtl_dbg(rtlpriv, COMP_SCAN, DBG_TRACE, "switch to channel%d, band type is %d\n",
Clang static checker warning: Value stored to 'v1' is never read [deadcode.DeadStores] Value stored to 'channel' is never read [deadcode.DeadStores] Remove them to save some place. Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)