diff mbox series

[PATHv11,28/43] configs/turris_omnia_defconfig: enable LTO

Message ID 20231127125726.3735-29-maxim.uvarov@linaro.org
State New
Headers show
Series net/lwip: add lwip library for the network stack | expand

Commit Message

Maxim Uvarov Nov. 27, 2023, 12:57 p.m. UTC
Decrease allowed binary size to fit lwip code.
u-boot-with-spl.kwb exceeds file size limit:
  limit:  0xf6000 bytes
  actual: 0xf8600 bytes
  excess: 0x2600 bytes

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 configs/turris_omnia_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Behún Nov. 27, 2023, 3:59 p.m. UTC | #1
On 2023-11-27 06:57, Maxim Uvarov wrote:
> Decrease allowed binary size to fit lwip code.
> u-boot-with-spl.kwb exceeds file size limit:
>   limit:  0xf6000 bytes
>   actual: 0xf8600 bytes
>   excess: 0x2600 bytes
> 
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  configs/turris_omnia_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/turris_omnia_defconfig 
> b/configs/turris_omnia_defconfig
> index afcd4a1eb7..4e965c795a 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -118,3 +118,4 @@ CONFIG_USB_EHCI_HCD=y
>  CONFIG_WDT=y
>  CONFIG_WDT_ORION=y
>  CONFIG_EXT4_WRITE=y
> +CONFIG_LTO=y

The last time I tried enabling LTO for omnia, the mvneta driver stopped 
working correctly. So this first need to test everything thoroughly.

Marek
Marek Behún Dec. 19, 2023, 9:38 a.m. UTC | #2
On Mon, 27 Nov 2023 18:57:11 +0600
Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> Decrease allowed binary size to fit lwip code.
> u-boot-with-spl.kwb exceeds file size limit:
>   limit:  0xf6000 bytes
>   actual: 0xf8600 bytes
>   excess: 0x2600 bytes
> 
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  configs/turris_omnia_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index afcd4a1eb7..4e965c795a 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -118,3 +118,4 @@ CONFIG_USB_EHCI_HCD=y
>  CONFIG_WDT=y
>  CONFIG_WDT_ORION=y
>  CONFIG_EXT4_WRITE=y
> +CONFIG_LTO=y

I finally tested it and LTO is currently broken on Omnia:

  Missing DTB
  spl_init() failed: -2
  ### ERROR ### Please RESET the board ###

Marek
Marek Behún Dec. 19, 2023, 2:37 p.m. UTC | #3
On Tue, 19 Dec 2023 10:38:33 +0100
Marek Behún <marek.behun@nic.cz> wrote:

> On Mon, 27 Nov 2023 18:57:11 +0600
> Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> 
> > Decrease allowed binary size to fit lwip code.
> > u-boot-with-spl.kwb exceeds file size limit:
> >   limit:  0xf6000 bytes
> >   actual: 0xf8600 bytes
> >   excess: 0x2600 bytes
> > 
> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> > ---
> >  configs/turris_omnia_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> > index afcd4a1eb7..4e965c795a 100644
> > --- a/configs/turris_omnia_defconfig
> > +++ b/configs/turris_omnia_defconfig
> > @@ -118,3 +118,4 @@ CONFIG_USB_EHCI_HCD=y
> >  CONFIG_WDT=y
> >  CONFIG_WDT_ORION=y
> >  CONFIG_EXT4_WRITE=y
> > +CONFIG_LTO=y  
> 
> I finally tested it and LTO is currently broken on Omnia:
> 
>   Missing DTB
>   spl_init() failed: -2
>   ### ERROR ### Please RESET the board ###
> 
> Marek

I take it back, it was cause by my toolchain.

Seems that LTO can be enabled on omnia.

Is this patchset still active? Or should I send a separate patch to
u-boot-marvell?

Marek
diff mbox series

Patch

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index afcd4a1eb7..4e965c795a 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -118,3 +118,4 @@  CONFIG_USB_EHCI_HCD=y
 CONFIG_WDT=y
 CONFIG_WDT_ORION=y
 CONFIG_EXT4_WRITE=y
+CONFIG_LTO=y