gstreamer1.0-plugins-bad: add packageconfig for egl

Message ID 1472219341-21220-1-git-send-email-nicolas.dechesne@linaro.org
State New
Headers show

Commit Message

Nicolas Dechesne Aug. 26, 2016, 1:49 p.m.
In commit 9c3a94aea1d (gstreamer1.0-plugins-bad: Move EGL requirement for
Wayland), --enable-egl was explicitely added to the wayland packageconfig. While
this is correct that enabling wayland requires egl, it should be possible to
enable egl without wayland, even when using X11. For example, glimagesink can be
used for GPU based color conversion using EGL/GLES.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj Aug. 26, 2016, 11:39 p.m. | #1
On 8/26/16 6:49 AM, Nicolas Dechesne wrote:
> In commit 9c3a94aea1d (gstreamer1.0-plugins-bad: Move EGL requirement for

> Wayland), --enable-egl was explicitely added to the wayland packageconfig. While

> this is correct that enabling wayland requires egl, it should be possible to

> enable egl without wayland, even when using X11. For example, glimagesink can be

> used for GPU based color conversion using EGL/GLES.


the default PACKAGECONFIG coming out of recipe should append 'egl'
unconditionally, if wayland is set in DISTRO_FEATURES. otherwise it will
confuse the semantics if its hardcoded in packageocnfig for wayland

> 

> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

> ---

>  meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc

> index d8c8179..1a94d1a 100644

> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc

> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc

> @@ -32,6 +32,7 @@ PACKAGECONFIG[curl]            = "--enable-curl,--disable-curl,curl"

>  PACKAGECONFIG[dash]            = "--enable-dash,--disable-dash,libxml2"

>  PACKAGECONFIG[directfb]        = "--enable-directfb,--disable-directfb,directfb"

>  PACKAGECONFIG[dtls]            = "--enable-dtls,--disable-dtls,openssl"

> +PACKAGECONFIG[egl]             = "--enable-egl,--disable-egl,virtual/egl"

>  PACKAGECONFIG[faac]            = "--enable-faac,--disable-faac,faac"

>  PACKAGECONFIG[faad]            = "--enable-faad,--disable-faad,faad2"

>  PACKAGECONFIG[flite]           = "--enable-flite,--disable-flite,flite-alsa"

> 

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
index d8c8179..1a94d1a 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
@@ -32,6 +32,7 @@  PACKAGECONFIG[curl]            = "--enable-curl,--disable-curl,curl"
 PACKAGECONFIG[dash]            = "--enable-dash,--disable-dash,libxml2"
 PACKAGECONFIG[directfb]        = "--enable-directfb,--disable-directfb,directfb"
 PACKAGECONFIG[dtls]            = "--enable-dtls,--disable-dtls,openssl"
+PACKAGECONFIG[egl]             = "--enable-egl,--disable-egl,virtual/egl"
 PACKAGECONFIG[faac]            = "--enable-faac,--disable-faac,faac"
 PACKAGECONFIG[faad]            = "--enable-faad,--disable-faad,faad2"
 PACKAGECONFIG[flite]           = "--enable-flite,--disable-flite,flite-alsa"