[android/device/linaro/pandaboard] Add vold.fstab

Message ID AANLkTin0Q6SjxStwn6DV+jKktWzF_krBHPMbqRpxjvV2@mail.gmail.com
State New
Headers show

Commit Message

Jeremy Chang March 23, 2011, 8:01 a.m.
vold.fstab is the vold configuration file to tell what the device to
mount.

Signed-off-by: Jeremy Chang <jeremy.chang@linaro.org>
---
 device.mk     |   16 ++++++++++++++++
 pandaboard.mk |    1 +
 vold.fstab    |   15 +++++++++++++++
 3 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 device.mk
 create mode 100644 vold.fstab

Comments

Patrik Ryd March 23, 2011, 1:46 p.m. | #1
On 23 March 2011 09:01, Jeremy Chang <jeremy.chang@linaro.org> wrote:

> vold.fstab is the vold configuration file to tell what the device to
> mount.
>
> Signed-off-by: Jeremy Chang <jeremy.chang@linaro.org>
> ---
>  device.mk     |   16 ++++++++++++++++
>  pandaboard.mk |    1 +
>  vold.fstab    |   15 +++++++++++++++
>  3 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 device.mk
>  create mode 100644 vold.fstab
>
> diff --git a/device.mk b/device.mk
> new file mode 100644
> index 0000000..79979e3
> --- /dev/null
> +++ b/device.mk
> @@ -0,0 +1,16 @@
> +# Copyright (C) 2010 The Android Open Source Project
>

Still think you should have Linaro above since you wrote this small file
from scratch.

 /Patrik


> +#
> +# Licensed under the Apache License, Version 2.0 (the "License");
> +# you may not use this file except in compliance with the License.
> +# You may obtain a copy of the License at
> +#
> +#      http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing, software
> +# distributed under the License is distributed on an "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> +# See the License for the specific language governing permissions and
> +# limitations under the License.
> +
> +PRODUCT_COPY_FILES := \
> +    device/linaro/beagleboard/vold.fstab:system/etc/vold.fstab
> diff --git a/pandaboard.mk b/pandaboard.mk
> index b7aab1c..7c15efd 100644
> --- a/pandaboard.mk
> +++ b/pandaboard.mk
> @@ -28,6 +28,7 @@ PRODUCT_PACKAGES := \
>     $(ZEROXBENCHMARK_NATIVE_APPS)
>
>  $(call inherit-product, $(SRC_TARGET_DIR)/product/core.mk)
> +$(call inherit-product, device/linaro/pandaboard/device.mk)
>
>  # Overrides
>  PRODUCT_BRAND := pandaboard
> diff --git a/vold.fstab b/vold.fstab
> new file mode 100644
> index 0000000..c17bb64
> --- /dev/null
> +++ b/vold.fstab
> @@ -0,0 +1,15 @@
> +## Vold 2.0 Generic fstab
> +## - San Mehat (san@android.com)
> +##
> +
> +#######################
> +## Regular device mount
> +##
> +## Format: dev_mount <label> <mount_point> <part> <sysfs_path1...>
> +## label        - Label for the volume
> +## mount_point  - Where the volume will be mounted
> +## part         - Partition # (1 based), or 'auto' for first usable
> partition.
> +## <sysfs_path> - List of sysfs paths to source devices
> +######################
> +
> +dev_mount sdcard /mnt/sdcard 7
> /devices/platform/mmci-omap-hs.0/mmc_host/mmc0
> --
> 1.7.1
>
Jeremy Chang March 23, 2011, 5:03 p.m. | #2
On Wed, Mar 23, 2011 at 9:46 PM, Patrik Ryd <patrik.ryd@linaro.org> wrote:
> On 23 March 2011 09:01, Jeremy Chang <jeremy.chang@linaro.org> wrote:
>>
>> vold.fstab is the vold configuration file to tell what the device to
>> mount.
>>
>> Signed-off-by: Jeremy Chang <jeremy.chang@linaro.org>
>> ---
>>  device.mk     |   16 ++++++++++++++++
>>  pandaboard.mk |    1 +
>>  vold.fstab    |   15 +++++++++++++++
>>  3 files changed, 32 insertions(+), 0 deletions(-)
>>  create mode 100644 device.mk
>>  create mode 100644 vold.fstab
>>
>> diff --git a/device.mk b/device.mk
>> new file mode 100644
>> index 0000000..79979e3
>> --- /dev/null
>> +++ b/device.mk
>> @@ -0,0 +1,16 @@
>> +# Copyright (C) 2010 The Android Open Source Project
>
> Still think you should have Linaro above since you wrote this small file
> from scratch.
>  /Patrik

Hi, Patrik,
    How should I add the linaro copyright? like below line?

# Copyright (C) 2011 Linaro - http://linaro.org

Actually the device.mk is written by taking
device/samsung/crespo/device.mk as reference.

I can resend the patch for adding the copyright in device.mk if it's
ok and you prefer.

Also, besides device.mk, will we add for other files in
device/linaro/beagleboard as well?

Thanks,
-Jeremy Chang

>
>>
>> +#
>> +# Licensed under the Apache License, Version 2.0 (the "License");
>> +# you may not use this file except in compliance with the License.
>> +# You may obtain a copy of the License at
>> +#
>> +#      http://www.apache.org/licenses/LICENSE-2.0
>> +#
>> +# Unless required by applicable law or agreed to in writing, software
>> +# distributed under the License is distributed on an "AS IS" BASIS,
>> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> +# See the License for the specific language governing permissions and
>> +# limitations under the License.
>> +
>> +PRODUCT_COPY_FILES := \
>> +    device/linaro/beagleboard/vold.fstab:system/etc/vold.fstab
>> diff --git a/pandaboard.mk b/pandaboard.mk
>> index b7aab1c..7c15efd 100644
>> --- a/pandaboard.mk
>> +++ b/pandaboard.mk
>> @@ -28,6 +28,7 @@ PRODUCT_PACKAGES := \
>>     $(ZEROXBENCHMARK_NATIVE_APPS)
>>
>>  $(call inherit-product, $(SRC_TARGET_DIR)/product/core.mk)
>> +$(call inherit-product, device/linaro/pandaboard/device.mk)
>>
>>  # Overrides
>>  PRODUCT_BRAND := pandaboard
>> diff --git a/vold.fstab b/vold.fstab
>> new file mode 100644
>> index 0000000..c17bb64
>> --- /dev/null
>> +++ b/vold.fstab
>> @@ -0,0 +1,15 @@
>> +## Vold 2.0 Generic fstab
>> +## - San Mehat (san@android.com)
>> +##
>> +
>> +#######################
>> +## Regular device mount
>> +##
>> +## Format: dev_mount <label> <mount_point> <part> <sysfs_path1...>
>> +## label        - Label for the volume
>> +## mount_point  - Where the volume will be mounted
>> +## part         - Partition # (1 based), or 'auto' for first usable
>> partition.
>> +## <sysfs_path> - List of sysfs paths to source devices
>> +######################
>> +
>> +dev_mount sdcard /mnt/sdcard 7
>> /devices/platform/mmci-omap-hs.0/mmc_host/mmc0
>> --
>> 1.7.1
>
>
Jim Huang March 24, 2011, 8:22 a.m. | #3
On 24 March 2011 01:03, Jeremy Chang <jeremy.chang@linaro.org> wrote:
[...]
> Hi, Patrik,
>    How should I add the linaro copyright? like below line?
>
> # Copyright (C) 2011 Linaro - http://linaro.org
>

hi Jeremy,

Please check the text description:
     https://wiki.linaro.org/Copyright

Regards,
-jserv
Patrik Ryd March 24, 2011, 8:39 a.m. | #4
On 23 March 2011 18:03, Jeremy Chang <jeremy.chang@linaro.org> wrote:

> On Wed, Mar 23, 2011 at 9:46 PM, Patrik Ryd <patrik.ryd@linaro.org> wrote:
> > On 23 March 2011 09:01, Jeremy Chang <jeremy.chang@linaro.org> wrote:
> >>
> >> vold.fstab is the vold configuration file to tell what the device to
> >> mount.
> >>
> >> Signed-off-by: Jeremy Chang <jeremy.chang@linaro.org>
> >> ---
> >>  device.mk     |   16 ++++++++++++++++
> >>  pandaboard.mk |    1 +
> >>  vold.fstab    |   15 +++++++++++++++
> >>  3 files changed, 32 insertions(+), 0 deletions(-)
> >>  create mode 100644 device.mk
> >>  create mode 100644 vold.fstab
> >>
> >> diff --git a/device.mk b/device.mk
> >> new file mode 100644
> >> index 0000000..79979e3
> >> --- /dev/null
> >> +++ b/device.mk
> >> @@ -0,0 +1,16 @@
> >> +# Copyright (C) 2010 The Android Open Source Project
> >
> > Still think you should have Linaro above since you wrote this small file
> > from scratch.
> >  /Patrik
>
> Hi, Patrik,
>    How should I add the linaro copyright? like below line?
>
> # Copyright (C) 2011 Linaro - http://linaro.org
>
> Actually the device.mk is written by taking
> device/samsung/crespo/device.mk as reference.
>

If you copied the file then keep the original copyright notice. If you
created it form scratch use Linaro copyright.


>
> I can resend the patch for adding the copyright in device.mk if it's
> ok and you prefer.
>
> Also, besides device.mk, will we add for other files in
> device/linaro/beagleboard as well?
>
> Thanks,
> -Jeremy Chang
>
> >
> >>
> >> +#
> >> +# Licensed under the Apache License, Version 2.0 (the "License");
> >> +# you may not use this file except in compliance with the License.
> >> +# You may obtain a copy of the License at
> >> +#
> >> +#      http://www.apache.org/licenses/LICENSE-2.0
> >> +#
> >> +# Unless required by applicable law or agreed to in writing, software
> >> +# distributed under the License is distributed on an "AS IS" BASIS,
> >> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >> implied.
> >> +# See the License for the specific language governing permissions and
> >> +# limitations under the License.
> >> +
> >> +PRODUCT_COPY_FILES := \
> >> +    device/linaro/beagleboard/vold.fstab:system/etc/vold.fstab
> >> diff --git a/pandaboard.mk b/pandaboard.mk
> >> index b7aab1c..7c15efd 100644
> >> --- a/pandaboard.mk
> >> +++ b/pandaboard.mk
> >> @@ -28,6 +28,7 @@ PRODUCT_PACKAGES := \
> >>     $(ZEROXBENCHMARK_NATIVE_APPS)
> >>
> >>  $(call inherit-product, $(SRC_TARGET_DIR)/product/core.mk)
> >> +$(call inherit-product, device/linaro/pandaboard/device.mk)
> >>
> >>  # Overrides
> >>  PRODUCT_BRAND := pandaboard
> >> diff --git a/vold.fstab b/vold.fstab
> >> new file mode 100644
> >> index 0000000..c17bb64
> >> --- /dev/null
> >> +++ b/vold.fstab
> >> @@ -0,0 +1,15 @@
> >> +## Vold 2.0 Generic fstab
> >> +## - San Mehat (san@android.com)
> >> +##
> >> +
> >> +#######################
> >> +## Regular device mount
> >> +##
> >> +## Format: dev_mount <label> <mount_point> <part> <sysfs_path1...>
> >> +## label        - Label for the volume
> >> +## mount_point  - Where the volume will be mounted
> >> +## part         - Partition # (1 based), or 'auto' for first usable
> >> partition.
> >> +## <sysfs_path> - List of sysfs paths to source devices
> >> +######################
> >> +
> >> +dev_mount sdcard /mnt/sdcard 7
> >> /devices/platform/mmci-omap-hs.0/mmc_host/mmc0
> >> --
> >> 1.7.1
> >
> >
>

Patch

diff --git a/device.mk b/device.mk
new file mode 100644
index 0000000..79979e3
--- /dev/null
+++ b/device.mk
@@ -0,0 +1,16 @@ 
+# Copyright (C) 2010 The Android Open Source Project
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+PRODUCT_COPY_FILES := \
+    device/linaro/beagleboard/vold.fstab:system/etc/vold.fstab
diff --git a/pandaboard.mk b/pandaboard.mk
index b7aab1c..7c15efd 100644
--- a/pandaboard.mk
+++ b/pandaboard.mk
@@ -28,6 +28,7 @@  PRODUCT_PACKAGES := \
     $(ZEROXBENCHMARK_NATIVE_APPS)

 $(call inherit-product, $(SRC_TARGET_DIR)/product/core.mk)
+$(call inherit-product, device/linaro/pandaboard/device.mk)

 # Overrides
 PRODUCT_BRAND := pandaboard
diff --git a/vold.fstab b/vold.fstab
new file mode 100644
index 0000000..c17bb64
--- /dev/null
+++ b/vold.fstab
@@ -0,0 +1,15 @@ 
+## Vold 2.0 Generic fstab
+## - San Mehat (san@android.com)
+##
+
+#######################
+## Regular device mount
+##
+## Format: dev_mount <label> <mount_point> <part> <sysfs_path1...>
+## label        - Label for the volume
+## mount_point  - Where the volume will be mounted
+## part         - Partition # (1 based), or 'auto' for first usable partition.
+## <sysfs_path> - List of sysfs paths to source devices
+######################
+
+dev_mount sdcard /mnt/sdcard 7 /devices/platform/mmci-omap-hs.0/mmc_host/mmc0