| Message ID | 1472475747-30296-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > It would make things a lot easier if you either consolidated all of these static changes into one patch, or released them as a series. Sean > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > index 6d3c501..4c4b5ab 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info) > } > } > > -void > +static void > gm107_grctx_generate_tpcid(struct gf100_gr *gr) > { > struct nvkm_device *device = gr->base.engine.subdev.device; > -- > 2.7.4 >
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c index 6d3c501..4c4b5ab 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info) } } -void +static void gm107_grctx_generate_tpcid(struct gf100_gr *gr) { struct nvkm_device *device = gr->base.engine.subdev.device;
We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4