From patchwork Tue Aug 30 11:26:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74973 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2095455qga; Tue, 30 Aug 2016 04:26:38 -0700 (PDT) X-Received: by 10.66.81.200 with SMTP id c8mr5348339pay.70.1472556398459; Tue, 30 Aug 2016 04:26:38 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pb1si44812635pac.1.2016.08.30.04.26.38 for ; Tue, 30 Aug 2016 04:26:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757884AbcH3L0g (ORCPT ); Tue, 30 Aug 2016 07:26:36 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34835 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755452AbcH3L0f (ORCPT ); Tue, 30 Aug 2016 07:26:35 -0400 Received: by mail-pf0-f176.google.com with SMTP id x72so7158199pfd.2 for ; Tue, 30 Aug 2016 04:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=TmYVal/0Rdu6FnN7Dcv/odw/fsr1GZp3rf2lSA20WpI=; b=Vt45/isvjkzDwnflNMs3pRmx/ECrdWnvsfb1MazWQrBlOx4trxtVFz0DtHZWiwomSu YJKhq4n2dti90oA0VKkHk9lL++oNQoaStp8+LEMuIcYOti1RxpW8RWf0cWTb3SKz6HDI M6LuNGm04MxBbmD42E9wgS3lDclSBQ0AnisPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TmYVal/0Rdu6FnN7Dcv/odw/fsr1GZp3rf2lSA20WpI=; b=kSt1uNnveEcv5hxZi/Y/CSYTb2EeUX371DRJfw4Fpyy2lej9ZGZi+AjgFVOJhaEBvT 51mmi8h6tVspxATUIA9XFX1HMkG/aC2fvYtRhvYd4FRjFaRgDR8CWZXAtm5FOuH9KVFV Mo5xwMB7EG0Sg401tUK7MIuI7Cj53c4rKw04QospZrYe2VpAp+RC7mDpo45Mb8WOVxjJ H6ln8JRP1M0yKCRArogbHIeu4TfU4msOjgT2UB7+lGSpJSEr5rDKe1oLzeubfxoh+Bvc vw2QLvYOQm8a1I7X+ZcooI9cC1t4EYe47J+tLLUfbLHgpf7LysnnCEfuA8wUYYq95NI9 XfkQ== X-Gm-Message-State: AE9vXwMq9/emRDev4W3c/5WBJoZakdHgVMnbQvjDySQqiSPXEsni9n9bL26UJ9MP0C6HjA2H X-Received: by 10.98.35.7 with SMTP id j7mr5276856pfj.39.1472556394562; Tue, 30 Aug 2016 04:26:34 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.62]) by smtp.gmail.com with ESMTPSA id k29sm56435803pfb.2.2016.08.30.04.26.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Aug 2016 04:26:34 -0700 (PDT) From: Baoyou Xie To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH v2] scsi: move function declarations to scsi_priv.h Date: Tue, 30 Aug 2016 19:26:00 +0800 Message-Id: <1472556360-22313-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org We get 2 warnings about global functions without a declaration in the scsi driver when building with W=1: drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes] drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes] in fact, both functions are declared in drivers/scsi/scsi_scan.c but need to move them into scsi_priv.h. Signed-off-by: Baoyou Xie Reviewed-by: Bart Van Assche --- drivers/scsi/scsi_priv.h | 2 ++ drivers/scsi/scsi_scan.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index 57a4b99..ff3cde3 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -85,12 +85,14 @@ extern void scsi_device_unbusy(struct scsi_device *sdev); extern void scsi_queue_insert(struct scsi_cmnd *cmd, int reason); extern void scsi_io_completion(struct scsi_cmnd *, unsigned int); extern void scsi_run_host_queues(struct Scsi_Host *shost); +extern void scsi_requeue_run_queue(struct work_struct *work); extern struct request_queue *scsi_alloc_queue(struct scsi_device *sdev); extern struct request_queue *scsi_mq_alloc_queue(struct scsi_device *sdev); extern int scsi_mq_setup_tags(struct Scsi_Host *shost); extern void scsi_mq_destroy_tags(struct Scsi_Host *shost); extern int scsi_init_queue(void); extern void scsi_exit_queue(void); +extern void scsi_evt_thread(struct work_struct *work); struct request_queue; struct request; extern struct kmem_cache *scsi_sdb_cache; diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index e0a78f5..212e98d 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -217,8 +217,6 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget, struct scsi_device *sdev; int display_failure_msg = 1, ret; struct Scsi_Host *shost = dev_to_shost(starget->dev.parent); - extern void scsi_evt_thread(struct work_struct *work); - extern void scsi_requeue_run_queue(struct work_struct *work); sdev = kzalloc(sizeof(*sdev) + shost->transportt->device_size, GFP_ATOMIC);