| Message ID | 1472635831-20290-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Accepted |
| Commit | ea2f7321a9029194a31ff9f798a8276d45747bcd |
| Headers | show |
On Wednesday, August 31, 2016 5:30:31 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/regulator/hi6421-regulator.c:480:14: warning: no previous prototype for > 'hi6421_regulator_ldo_get_optimum_mode' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Acked-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/regulator/hi6421-regulator.c b/drivers/regulator/hi6421-regulator.c index 42dc5fb..62c5f54 100644 --- a/drivers/regulator/hi6421-regulator.c +++ b/drivers/regulator/hi6421-regulator.c @@ -477,7 +477,8 @@ static int hi6421_regulator_buck_set_mode(struct regulator_dev *rdev, return 0; } -unsigned int hi6421_regulator_ldo_get_optimum_mode(struct regulator_dev *rdev, +static unsigned int +hi6421_regulator_ldo_get_optimum_mode(struct regulator_dev *rdev, int input_uV, int output_uV, int load_uA) { struct hi6421_regulator_info *info = rdev_get_drvdata(rdev);
We get 1 warning when building kernel with W=1: drivers/regulator/hi6421-regulator.c:480:14: warning: no previous prototype for 'hi6421_regulator_ldo_get_optimum_mode' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/regulator/hi6421-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.7.4