| Message ID | 20231205-qcom_stats-aoss_qmp-dependency-v1-1-8dabe1b5c32a@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 70b139a7af7106b59ca5ca77673a9c56982b3089 |
| Headers | show |
| Series | soc: qcom: stats: Express AOSS QMP module dependency | expand |
On Tue, 05 Dec 2023 20:38:40 -0800, Bjorn Andersson wrote: > In the case that the Qualcomm Sleep stats driver is builtin and the AOSS > QMP driver is built as a module, neither the implementation nor the stub > functions are available during linking, resulting in the following > errors: > > qcom_stats.c:(.text+0x33c): undefined reference to `qmp_send' > qcom_stats.c:(.text+0x8a0): undefined reference to `qmp_get' > > [...] Applied, thanks! [1/1] soc: qcom: stats: Express AOSS QMP module dependency commit: 70b139a7af7106b59ca5ca77673a9c56982b3089 Best regards,
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 2686fda9fe27..aa5956246f60 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -221,6 +221,7 @@ config QCOM_STATS tristate "Qualcomm Technologies, Inc. (QTI) Sleep stats driver" depends on (ARCH_QCOM && DEBUG_FS) || COMPILE_TEST depends on QCOM_SMEM + depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n help Qualcomm Technologies, Inc. (QTI) Sleep stats driver to read the shared memory exported by the remote processor related to
In the case that the Qualcomm Sleep stats driver is builtin and the AOSS QMP driver is built as a module, neither the implementation nor the stub functions are available during linking, resulting in the following errors: qcom_stats.c:(.text+0x33c): undefined reference to `qmp_send' qcom_stats.c:(.text+0x8a0): undefined reference to `qmp_get' Resolve this by expressing the dependency between the two modules. Fixes: e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/linux-arm-msm/202312061258.nAVYPFq2-lkp@intel.com/ Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) --- base-commit: adcad44bd1c73a5264bff525e334e2f6fc01bb9b change-id: 20231205-qcom_stats-aoss_qmp-dependency-e7505d2259a4 Best regards,