| Message ID | 20231206221841.15685-1-paul@crapouillou.net |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND] drm/exynos: dpi: Change connector type to DPI | expand |
Hi Paul, > -----Original Message----- > From: Paul Cercueil <paul@crapouillou.net> > Sent: Thursday, December 7, 2023 7:19 AM > To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim > <sw0312.kim@samsung.com>; Kyungmin Park <kyungmin.park@samsung.com>; > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar > <alim.akhtar@samsung.com> > Cc: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; > dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; > linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; Paul > Cercueil <paul@crapouillou.net> > Subject: [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI > > When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not exist > yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was used as > the connector type. > > However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as the > connector type. Sorry for late. Merged. Thanks, Inki Dae > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c > b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > index 378e5381978f..0dc36df6ada3 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > @@ -101,7 +101,7 @@ static int exynos_dpi_create_connector(struct > drm_encoder *encoder) > > ret = drm_connector_init(encoder->dev, connector, > &exynos_dpi_connector_funcs, > - DRM_MODE_CONNECTOR_VGA); > + DRM_MODE_CONNECTOR_DPI); > if (ret) { > DRM_DEV_ERROR(ctx->dev, > "failed to initialize connector with drm\n"); > -- > 2.42.0 >
Le jeudi 07 décembre 2023 à 11:42 +0900, 대인기/Tizen Platform Lab(SR)/삼성전자 a écrit : > Hi Paul, > > > -----Original Message----- > > From: Paul Cercueil <paul@crapouillou.net> > > Sent: Thursday, December 7, 2023 7:19 AM > > To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim > > <sw0312.kim@samsung.com>; Kyungmin Park > > <kyungmin.park@samsung.com>; > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar > > <alim.akhtar@samsung.com> > > Cc: David Airlie <airlied@gmail.com>; Daniel Vetter > > <daniel@ffwll.ch>; > > dri-devel@lists.freedesktop.org; > > linux-arm-kernel@lists.infradead.org; > > linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; > > Paul > > Cercueil <paul@crapouillou.net> > > Subject: [PATCH RESEND] drm/exynos: dpi: Change connector type to > > DPI > > > > When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not > > exist > > yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was > > used as > > the connector type. > > > > However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as > > the > > connector type. > > Sorry for late. Merged. No problem. Thank you! Cheers, -Paul > > Thanks, > Inki Dae > > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > --- > > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c > > b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > > index 378e5381978f..0dc36df6ada3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > > @@ -101,7 +101,7 @@ static int exynos_dpi_create_connector(struct > > drm_encoder *encoder) > > > > ret = drm_connector_init(encoder->dev, connector, > > &exynos_dpi_connector_funcs, > > - DRM_MODE_CONNECTOR_VGA); > > + DRM_MODE_CONNECTOR_DPI); > > if (ret) { > > DRM_DEV_ERROR(ctx->dev, > > "failed to initialize connector with > > drm\n"); > > -- > > 2.42.0 > > > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 378e5381978f..0dc36df6ada3 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -101,7 +101,7 @@ static int exynos_dpi_create_connector(struct drm_encoder *encoder) ret = drm_connector_init(encoder->dev, connector, &exynos_dpi_connector_funcs, - DRM_MODE_CONNECTOR_VGA); + DRM_MODE_CONNECTOR_DPI); if (ret) { DRM_DEV_ERROR(ctx->dev, "failed to initialize connector with drm\n");
When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not exist yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was used as the connector type. However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as the connector type. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)