[01/15,v2] iio: accel: kxsd9: Fix scaling bug

Message ID 1472723089-25113-1-git-send-email-linus.walleij@linaro.org
State Accepted
Commit 307fe9dd11ae44d4f8881ee449a7cbac36e1f5de
Headers show

Commit Message

Linus Walleij Sept. 1, 2016, 9:44 a.m.
All the scaling of the KXSD9 involves multiplication with a
fraction number < 1.

However the scaling value returned from IIO_INFO_SCALE was
unpredictable as only the micros of the value was assigned, and
not the integer part, resulting in scaling like this:

$cat in_accel_scale

Fix this by assigning zero to the integer part.

Cc: stable@vger.kernel.org
Tested-by: Jonathan Cameron <jic23@kernel.org>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

ChangeLog v1->v2:
- Move this first in the series as Jonathan's request.
 drivers/iio/accel/kxsd9.c | 1 +
 1 file changed, 1 insertion(+)


To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
index da5fb67ecb34..9d72d4bcf5e9 100644
--- a/drivers/iio/accel/kxsd9.c
+++ b/drivers/iio/accel/kxsd9.c
@@ -166,6 +166,7 @@  static int kxsd9_read_raw(struct iio_dev *indio_dev,
 		ret = spi_w8r8(st->us, KXSD9_READ(KXSD9_REG_CTRL_C));
 		if (ret < 0)
 			goto error_ret;
+		*val = 0;
 		*val2 = kxsd9_micro_scales[ret & KXSD9_FS_MASK];