| Message ID | 20231211212003.21686-7-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | exec: Rework of various headers (user focused) | expand |
On 12/11/23 13:19, Philippe Mathieu-Daudé wrote: > Nothing in guestfd.c requires "semihosting/uaccess.h". > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > semihosting/guestfd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c > index 955c2efbd0..fd7e609790 100644 > --- a/semihosting/guestfd.c > +++ b/semihosting/guestfd.c > @@ -15,7 +15,6 @@ > #ifdef CONFIG_USER_ONLY > #include "qemu.h" > #else > -#include "semihosting/uaccess.h" Then I would be surprised if qemu.h is required either -- that's where uaccess is done for user-only. r~
On 12/12/23 00:00, Richard Henderson wrote: > On 12/11/23 13:19, Philippe Mathieu-Daudé wrote: >> Nothing in guestfd.c requires "semihosting/uaccess.h". >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> semihosting/guestfd.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c >> index 955c2efbd0..fd7e609790 100644 >> --- a/semihosting/guestfd.c >> +++ b/semihosting/guestfd.c >> @@ -15,7 +15,6 @@ >> #ifdef CONFIG_USER_ONLY >> #include "qemu.h" >> #else >> -#include "semihosting/uaccess.h" > > Then I would be surprised if qemu.h is required either -- that's where > uaccess is done for user-only. Indeed we can remove it.
diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c index 955c2efbd0..fd7e609790 100644 --- a/semihosting/guestfd.c +++ b/semihosting/guestfd.c @@ -15,7 +15,6 @@ #ifdef CONFIG_USER_ONLY #include "qemu.h" #else -#include "semihosting/uaccess.h" #include CONFIG_DEVICES #endif
Nothing in guestfd.c requires "semihosting/uaccess.h". Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- semihosting/guestfd.c | 1 - 1 file changed, 1 deletion(-)