| Message ID | 1473148256-25347-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote: > #include <linux/kernel.h> > #include <linux/string.h> > +#include <coda.h> > by convention, we tend to write this as #include "coda.h" otherwise the patch looks good to me, Acked-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c index 456773a..09dfcca 100644 --- a/drivers/media/platform/coda/coda-h264.c +++ b/drivers/media/platform/coda/coda-h264.c @@ -13,6 +13,7 @@ #include <linux/kernel.h> #include <linux/string.h> +#include <coda.h> static const u8 coda_filler_nal[14] = { 0x00, 0x00, 0x00, 0x01, 0x0c, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x80 };
We get 1 warning when building kernel with W=1: drivers/media/platform/coda/coda-h264.c:22:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes] In fact, this function is declared in coda.h, so this patch add missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/media/platform/coda/coda-h264.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4